Bug 208272
| Summary: | ports-mgmt/portlint: spurious warning without PORTSDIR | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | bapt, gerald, jrm, ngie, pi | ||||
| Priority: | --- | Flags: | amdmi3:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | 203685 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 168603 [details]
Patch that should fix it
Here is a patch that should fix it
(In reply to Baptiste Daroussin from comment #1) Yeah, that seems correct.. (In reply to Ngie Cooper from comment #2) Well, with exception of the fact that I would probably avoid a greedy glob, i.e. use `+` instead of `*`. See also my simpler patch https://reviews.freebsd.org/D5843 which drops support for ${PORTSDIR} completely. I agree Dmitry has a better version :) *** Bug 208673 has been marked as a duplicate of this bug. *** Maintainer timeout. Jan, Ngie, any objections for committing my version? I have committed Dmitry's patch to my CVS repo pending the next release (very soon). Great, thank you! Moving to In Progress. A commit references this bug: Author: marcus Date: Fri Apr 15 18:30:42 UTC 2016 New revision: 413367 URL: https://svnweb.freebsd.org/changeset/ports/413367 Log: Update to 2.17.0. * Drop the need for PORTSDIR in dependencies [1] * Allow a trailing ':' in URLs [2] * Check to make sure the value(s) of SUB_FILES is healthy [3] * Expand variables on all sides of the dependency tuple [4] (this last change is rather big, and thus bumping minor version) PR: 208272 [1] 207843 [2] 207477 [3] 206061 [4] Submitted by: amdmi3 [1] Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/src/portlint.pl Committed, thanks! |
Adding ${PORTSDIR} on _DEPENDS line is no longer necessary since 2016Q1 branched. I've added a few ports with it e.g., $ cd devel/py-re2; portlint -C WARN: Makefile: no port directory lang/cython found, even though it is listed in BUILD_DEPENDS. WARN: Makefile: no port directory devel/re2 found, even though it is listed in LIB_DEPENDS. 0 fatal errors and 2 warnings found.