Bug 209055
| Summary: | make delete-old and WITHOUT_LEGACY_CONSOLE=true doesn't remove superfluous files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Philippe Michel <philippe.michel7> | ||||
| Component: | misc | Assignee: | Mark Linimon <linimon> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | linimon | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | 10.3-RELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Is this PR still relevant? It seems it has been fixed at some point. At least, on the 11-STABLE version I now use, a change similar to the patch I had attached to the PR has been applied to tools/build/mk/OptionalObsoleteFiles.inc. That said, I no longer use WITHOUT_LEGACY_CONSOLE since it breaks kernel builds using the KBDMUX_DFLT_KEYMAP option (see sys/conf/files and the "kbdmuxmap.h ... compile-with kbdcontrol ..." line). That is, whether you use legacy console or vt, to support other keyboards than standard qwerty early enough for them to be available in single user mode, you need kbdcontrol and the latter depends on LEGACY_CONSOLE. I suppose this last point deserves a separate PR (maybe there is already one) but when I stumbled on the issue I was just re-enabled the option. |
Created attachment 169696 [details] Possible patch If WITHOUT_LEGACY_CONSOLE is set to true, "make delete-old" doesn't remove the files that may remain from when this option was not used.