Bug 209465

Summary: lang/go: Thinks it's compiled gcc
Product: Ports & Packages Reporter: Steven Hartland <smh>
Component: Individual Port(s)Assignee: Julien Laffaye <jlaffaye>
Status: Closed FIXED    
Severity: Affects Only Me CC: smh
Priority: --- Flags: bugzilla: maintainer-feedback? (jlaffaye)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to remove CC from go build none

Description Steven Hartland freebsd_committer freebsd_triage 2016-05-12 14:28:43 UTC 
Created attachment 170228 [details]
Patch to remove CC from go build

go 1.6 introduced a default to clang when run under FreeBSD however for said tests to work CC must not be set.
https://github.com/golang/go/commit/d8dd9c714b9700bfb3e79a06172d37738179d511

Setting CC when building go results in it thinking its using gcc and hence outputs incorrect warnings e.g.

go test -race -v
# os/user
cc: warning: argument unused during compilation: '-pthread'
# net
cc: warning: argument unused during compilation: '-pthread'
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-18 21:30:48 UTC 
A commit references this bug:

Author: jlaffaye
Date: Sat Feb 18 21:30:15 UTC 2017
New revision: 434383
URL: https://svnweb.freebsd.org/changeset/ports/434383

Log:
  - Update to 1.8
  - Add option to disable SSE2 [1]
  - Remove CC when calling make.bash [2]

  PR:		210612, 209465

Changes:
  head/lang/go/Makefile
  head/lang/go/distinfo
  head/lang/go/pkg-plist