Bug 209465 - lang/go: Thinks it's compiled gcc
Summary: lang/go: Thinks it's compiled gcc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-12 14:28 UTC by Steven Hartland
Modified: 2017-02-18 21:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments
Patch to remove CC from go build (496 bytes, patch)
2016-05-12 14:28 UTC, Steven Hartland
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Hartland freebsd_committer 2016-05-12 14:28:43 UTC
Created attachment 170228 [details]
Patch to remove CC from go build

go 1.6 introduced a default to clang when run under FreeBSD however for said tests to work CC must not be set.
https://github.com/golang/go/commit/d8dd9c714b9700bfb3e79a06172d37738179d511

Setting CC when building go results in it thinking its using gcc and hence outputs incorrect warnings e.g.

go test -race -v
# os/user
cc: warning: argument unused during compilation: '-pthread'
# net
cc: warning: argument unused during compilation: '-pthread'
Comment 1 commit-hook freebsd_committer 2017-02-18 21:30:48 UTC
A commit references this bug:

Author: jlaffaye
Date: Sat Feb 18 21:30:15 UTC 2017
New revision: 434383
URL: https://svnweb.freebsd.org/changeset/ports/434383

Log:
  - Update to 1.8
  - Add option to disable SSE2 [1]
  - Remove CC when calling make.bash [2]

  PR:		210612, 209465

Changes:
  head/lang/go/Makefile
  head/lang/go/distinfo
  head/lang/go/pkg-plist