Bug 209493
| Summary: | [MAINTAINER] audio/pd - Fix inbuilt documentation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Brodel <brittlehaus> | ||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | brittlehaus, pi | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 170268 [details]
poudriere log for audio/pd
Committed, thanks! A commit references this bug: Author: pi Date: Sat May 14 15:08:08 UTC 2016 New revision: 415189 URL: https://svnweb.freebsd.org/changeset/ports/415189 Log: audio/pd: Fix builtin documentation - also pet portlint PR: 209493 Submitted by: Tobias Brodel <brittlehaus@gmail.com> (maintainer) Changes: head/audio/pd/Makefile head/audio/pd/files/patch-extra_pd_pd.c head/audio/pd/files/patch-src_s__main.c |
Created attachment 170267 [details] svn diff for audio/pd Currently the inbuilt documentation in Pd cannot be accessed: the help browser cannot find its references and inbuilt objects cannot find their help-patches. This diff removes files/patch-src_s__main.c which intends to point pd towards to ${LOCALBASE}/share/doc/pd instead of ${LOCALBASE}/lib/pd/doc. Unfortunately the patch actually ends up telling Pd to look in ${LOCALBASE}/lib/pd/share/doc/pd, a nonexistent directory. The do-install target already symlinks ${LOCALBASE}/share/doc/pd to ${LOCALBASE}/lib/pd/doc which is all Pd needs to find its docs. The patch I'm proposing to remove actually breaks this functionality. ----------- Also included in the diff are some changes to satisfy portlint: I've removed an explicit reference to /usr/bin/tclsh and regenerated files/patch-extra_pd_pd.c with `make makepatch` which renamed it as `files/patch-extra_pd~_pd~.c. Finally I've modified the post-patch target to reflect patches I got merged upstream: all references to alloca.h are now #ifdeffed to only apply to OS X and Linux within the Pd base. Only third-party libraries (files under ${WRKSRC}/extra) still contain non-portable includes.