Bug 210567
| Summary: | www/lessc: building is occurring in stage phase, this is incorrect | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Marino <marino> |
| Component: | Individual Port(s) | Assignee: | Rodrigo Osorio <rodrigo> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(rodrigo) |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
A commit references this bug: Author: marino Date: Sat Aug 27 21:34:27 UTC 2016 New revision: 420999 URL: https://svnweb.freebsd.org/changeset/ports/420999 Log: www/lessc: Moving building out of stage phase, fix stage-QA This port would build and install in the stage phase, but building is supposed to be complete by then. Moreover, stage QA checks complain about thousands of "orphaned" files and symbolic links with absolute paths. Fix all the problems by installing in a temporary build directory and moving just the lessc files over the stage directory, and fix the symbolic link by defining a relative path instead. Functionally, the new package is the same as the old one, so no revbump is required. PR: 210567 Approved by: maintainer timeout (2 months) Changes: head/www/lessc/Makefile |
I don't know anything about npm, but it appears to be both building and installing in one step. ----- do-install: (cd ${STAGEDIR}${PREFIX}/lib ; ${SETENV} HOME=${WRKDIR} npm install ${WRKSRC}) # this is a dirty hack ${LN} -s ${PREFIX}/lib/node_modules/.bin/lessc ${STAGEDIR}${PREFIX}/bin/lessc ----- I would think this needs to be broken into two steps, e.g. convert do-install to do-build and install it in a temporary location, and then add a new do-install that copies it to the stage directory. There should be no building at all during the stage phase ideally, only copying.