Bug 211182
| Summary: | deskutils/taskwarrior: Add many language OPTIONS | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | ribbon <ppp15478> |
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> |
| Status: | Closed Not Accepted | ||
| Severity: | Affects Some People | CC: | skreuzer, w.schwarzenfeld |
| Priority: | --- | Keywords: | feature, needs-qa, patch |
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(skreuzer) |
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Correctly assign to maintainer I'm not sure OPTIONS_SINGLE is the most appropriate choice. Are there existing examples of other ports doing this? What about multiple selections (OPTIONS_MULTI), or one OPTION for all languages, or a slave port with SUFFIX -languages? Or slave ports for each -lang in their respective categories? (In reply to ribbon from comment #0) This also changes PORTVERSION to 2.5.1 but distinfo needs to be updated and the patches under files/ don't cleanly apply (In reply to Kubilay Kocak from comment #1) > What about multiple selections (OPTIONS_MULTI), With OPTIONS_MULTI, it can select two or more items. But, Language that can be selected in the option is only one. Therefore, I chose OPTIONS_SINGLE. The choice of language is the same in each language. Therefore, I think that there is no need to divide into slave ports. Created attachment 173291 [details]
update taskwarrior patch for enable language select (Makefile)
update Makefile for enable language select
Created attachment 173292 [details]
distinfo file for taskwarior 2.5.1
distinfo file for taskwarrior 2.5.1
Created attachment 173293 [details]
patch for taskwarrior 2.5.1
Created attachment 173294 [details]
src_commands_CmdTimesheet.cpp patch for 2.5.1
Created attachment 173295 [details]
src_commands_CmdEdit.cpp patch for 2.5.1
Created attachment 173296 [details]
src_commands_CmdTimesheet.cpp patch for 2.5.1
Created attachment 173297 [details]
patch-src_ISO8601.cpp patch for 2.5.1
Created attachment 173298 [details]
patch-src_ISO8601.h patch for 2.5.1
Created attachment 173299 [details]
patch-src_recur.cpp patch for 2.5.1
Created attachment 173300 [details]
patch-src_Task.cpp patch for 2.5.1
I update patch for taskwarrior 2.5.1. 1) update files/* for 2.5.1 2) update distinfo for 2.5.1 3) update Makefile. in Mk/bsd.options.desc.mk , LANG_xx_DESC is already defined,so I delete it in Makefile. Maintainer feedback? The submission is not in patch form (i.e., a unified diff as described in the Porter's Handbook [1] instead of a raw upload of the port files), so it's hard to review and do anything with it. As it stands this is rejected. [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html#svn-diff |
Created attachment 172623 [details] taskwarrior patch for enable language select taskwarrior patch for enable language select. tested FreeBSD 9.3 i386 environment.