Bug 211923
| Summary: | www/phalcon: Update to 3.0.1 (Adds PHP 7.0 support) | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Franco Fichtner <franco> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Torsten Zuehlsdorff <tz> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | linpct, tz | ||||||||||||||
| Priority: | --- | Keywords: | easy | ||||||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(linpct) |
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Franco Fichtner
2016-08-17 06:31:24 UTC
Hi, any built log? Thanks. Want one for PHP 5.6 or PHP 7.0? :) PHP 5.6 runtime test looks good so far. @Franco, does this obsolete bug 211359? Please confirm successful QA on both PHP 5 and /7 please Created attachment 173777 [details]
PHP 5.6 testport output
Created attachment 173778 [details]
PHP 7.0 testport output
Hi Kubilay, Yes, it would obsolete the other issue. The proposed patch adds armv6 support too. Cheers, Franco Comment on attachment 173764 [details]
0002: 3.0.0 rework
Maintainer approved, thanks.
*** Bug 211359 has been marked as a duplicate of this bug. *** Hi, Currently 3.0.1 had released, will provide 3.0.1 patch? Thanks. Hi, I can provide one today after some testing, though I'd rather wrap this up first and open a new issue? Cheers, Franco Created attachment 174056 [details]
0003: patch for 3.0.1
I haven't given it the full round of testing, but unit tests and GUI rendering and API operation works within OPNsense. Feel free to ack now or defer.
Created attachment 174057 [details]
0001: armv6 additions
In accordance with tz@, I've uploaded all the patches and marked them in their apply order as they all depend on each other. Comment on attachment 174056 [details]
0003: patch for 3.0.1
approved!
Comment on attachment 174057 [details]
0001: armv6 additions
would this still work on 3.0.1?
Created attachment 174089 [details]
ARMv6 build log for Phalcon 3.0.1 on PHP 5.6
I've attached an OPNsense build log as I don't have Poudriere set up to cross-build. Works fine.
So i'm confused right now. Which patch to apply/test/commit? Is there one big to check? This has been rather confusing and time-consuming... https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211359 added ARMv6 support and should have been approved by maintainer timeout a while back. It was falsely closed as a duplicate. ;) This armv6 support patch is now incorporated into this issue as patch 0001 by request of koobs@. The next patch 0002 builds on top of 0001 and adds 3.0.0. It was approved by the maintainer. The next patch 0003 builds on top of 0002 and adds 3.0.1 as per request of the maintainer. It was also approved. Do you want me to condense all the patches into a single one? (In reply to Franco Fichtner from comment #18) > Do you want me to condense all the patches into a single one? No thanks, i did it by myself with your explanation. Testbuilds are running now. :) Good morning, Looks like this is still pending. :) Cheers, Franco (In reply to Franco Fichtner from comment #20) > Looks like this is still pending. :) Yes, i'm sorry. Wife got ill, to less time, etc. :/ Since i'm coming back right now i think i will get this PR done tomorrow. :) A commit references this bug: Author: tz Date: Fri Sep 23 08:27:59 UTC 2016 New revision: 422653 URL: https://svnweb.freebsd.org/changeset/ports/422653 Log: www/phalcon: Update from 2.0.13 to 3.0.1 Changes: https://github.com/phalcon/cphalcon/blob/v3.0.1/CHANGELOG.md Also add arm6 support PR: 211923 Submitted by: Franco Fichtner <franco@opnsense.org> Approved by: linpct@gmail.com (maintainer), swills (mentor) Changes: head/www/phalcon/Makefile head/www/phalcon/distinfo Committed, thanks :) |
