Bug 212111
| Summary: | ng_btsocket(4) lacks info on updated struct sockaddr_l2cap layout | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Documentation | Reporter: | Dmitry Marakasov <amdmi3> | ||||
| Component: | Manual Pages | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
| Status: | Open --- | ||||||
| Severity: | Affects Many People | CC: | doc, felix.the.red, takawata | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Created attachment 228205 [details]
ng_btsocket(4) patch and document sysctls
Update data structure to include new elements.
Document multiple missing sysctls.
|
/usr/include/netgraph/bluetooth/include/ng_btsocket.h from 11.0: struct sockaddr_l2cap { u_char l2cap_len; /* total length */ u_char l2cap_family; /* address family */ u_int16_t l2cap_psm; /* PSM (Protocol/Service Multiplexor) */ bdaddr_t l2cap_bdaddr; /* address */ u_int16_t l2cap_cid; /*cid*/ u_int8_t l2cap_bdaddr_type; /*address type*/ }; Last two fields were added in r281198 by takawata@: https://svnweb.freebsd.org/base/head/sys/netgraph/bluetooth/include/ng_btsocket.h?r1=180399&r2=281198 with warning telling to check new fields for being initialized. the same struct description from ng_btsocket(4): struct sockaddr_l2cap { u_char l2cap_len; /* total length */ u_char l2cap_family; /* address family */ uint16_t l2cap_psm; /* Protocol/Service Multiplexor */ bdaddr_t l2cap_bdaddr; /* address */ }; 1) The manpage should be updated 2) The new fields should be documented The latter is crucial for fixing numerous ports which have problems on 11.x (some fail to build because of warning and -Werror, others may fail in runtime because improperly initialized fields)