Bug 212211
| Summary: | [sysutils/smartmontools]: smartctl not able to access S.M.A.R.T data on drives connected to mrsas(4) RAID | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrii Stesin <stesin> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Oleksii Samorukov <samm> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | CC: | adamz, alex-freebsd-bugs, h, jpaetzel, pkubaj, samm, stesin, terry-freebsd, vrwmiller | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Andrii Stesin
2016-08-28 10:56:56 UTC
Sorry for misprint (missed bracket), I meant smartctl -a -d 'megaraid,[9:11]' BTW, while trying to reach AVAGO people who deal with mrsas (4) I opened the /usr/src/sys/dev/mrsas.c file, at line 4 it says: "Support: freebsdraid@avagotech.com" - this mail does not work, the mailbox is rejected by AVAGO. At the bottom of initial copyright message, there is another email listed: megaraidfbsd@avagotech.com and this one does not work either (also rejected). Maybe AVAGO dropped FreeBSD support at all? Or what I am doing wrong? I can confirm that sysutils/smartmontools doesn't work with mrsas(4). sysutils/storcli also doesn't work: [root@gen ~/storcli_all_os/FreeBSD]# storcli /call show all Status = Failure Description = No Controller found Using the newest storcli from AVAGO doesn't help: [root@gen ~/storcli_all_os/FreeBSD]# ./storcli64 /call show all Status = Failure Description = No Controller found Strangely, MegaCli works, but it doesn't provide enough functionality for me. Hi i am smartmontools developer. it should be possible to implement this functionality in the FreeBSD build. Please drop me a note in the ticket if you want to participate in testing. Yes, I'd be very interested in participating in testing. Just posting to register my interest in this as well. 12-STABLE amd64 with a SAS3108 (Dell PERC H730) controller, just in case this PR has been languishing because it was filed against a no-longer-supported FreeBSD release. The mfi driver package provided the mfip kernel module, which exposed each of the controller's drives as a passN device, regardless of configuration / array / etc. status. With some newer controllers only supported by mrsas, and mfi being deprecated (or at least not suggested as the path to the future), FreeBSD needs functionality similar to mfip in order for smartmontools (and perhaps other software) to work on drives attached to a mrsas controller. It looks like r342065 added a lot of the support needed for this to mrsas: https://svnweb.freebsd.org/base?view=revision&revision=342065 Perhaps someone more familiar with this driver could finish up adding passthru support? My company could contribute some reasonable funding (and test hardware) toward getting this implemented if necessary. Hi Terry. Please connect with me about adding this support, samm@os2.kiev.ua and samm@net-art.cz. I will need remote access to the hw ^Triage: assignee has returned his bit for safekeeping. Still present today with 13.0-CURRENT I did an experimental patch to support -d megaraid on FreeBSD, see https://patch-diff.githubusercontent.com/raw/smartmontools/smartmontools/pull/117.patch. I do not have any mrsas devices around, so was testing it on mfi only. Also was reversing storcli to find if it would do the same. Testing is welcome. See https://patch-diff.githubusercontent.com/raw/smartmontools/smartmontools/pull/117.patch for the patch itself. Created attachment 229665 [details] Sample output after patching (In reply to Oleksii Samorukov from comment #10) In basic testing, this seems to work - thank you! Attached is a log file showing status, start of a self-test, self-test in progress, and status after completed self-test. The patch to ChangeLog does not install because I think your patch is based on an unreleased version of smartmontools. However, that's cosmetic. Another cosmetic issue is that "megaraid" should probably be added to smart_interface::get_valid_dev_types_str() in dev_interface.cpp I will do some additional testing and report my findings. Thanks again! Created attachment 229666 [details]
Changes to daily periodic smart script
The attached patch enables daily SMART status reports as part of the nightly periodic jobs. The following needs to be added to /etc/periodic.conf (season to taste):
daily_status_smart_devices="mrsas0,0 mrsas0,1 mrsas0,2 mrsas0,3"
daily_status_smart_enable="YES"
I believe the patch to enable SMART support provides support for devices other than /dev/mrsas0. In that case, the attached patch will need to be extended to understand those additional devices.
(In reply to Terry Kennedy from comment #11) Thank you for testing and comments, glad to see its working. One of the things i would like to implement before merging it to master is scanning and hint for the mrsas exported block devices. From source code i see that its exporting block devices as /dev/da?. May i ask you to issue `smartctl -d scsi -i -r ioctl,3 /dev/daX` where daX is mrsas owned device? And also `camcontrol devlist -v` if possible. My intention is to detect that device is owned by mrsas and display hint about '-d megaraid,N' Created attachment 229667 [details]
Requested info
I'm attaching the output from the two commands you requested. /dev/da0 is a RAID5 of 4 SSDs. This is a PERC H730 (PCI card=0x1f491028 chip=0x005d1000) in a Dell PowerEdge R730.
There seems to be partial support for passthru in the mrsas driver. I think I noted this in my first comment on this PR.
There is quite a large amount of variation in the behavior of the various MegaRAID drivers in FreeBSD. mfi will expose all of the physical member disks as /dev/passX devices if the undocumented mfip module is loaded. One of the other MegaRAID drivers (mpr, maybe?) has an interesting misfeature of only exposing the last physical member disk of a volume as a /dev/passX device.
Thank you. I updated patch to support scanning, please try to test "smartctl --scan" and "smartctl --scan-open" commands to see if it works as expected P.S. I merged things to master already. Please test on https://github.com/smartmontools/smartmontools. If succeed - i will update the port. (In reply to Oleksii Samorukov from comment #16) What is the procedure to generate a configure script from the provided configure.ac file? Simply trying "autoconf" produces: configure.ac:7: error: possibly undefined macro: AM_INIT_AUTOMAKE If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:25: error: possibly undefined macro: AM_MAINTAINER_MODE configure.ac:30: error: possibly undefined macro: AM_PROG_AS configure.ac:91: error: possibly undefined macro: AM_CONDITIONAL It appears that the version of smartmontools in ports contains a "pre-cooked" configure script. > What is the procedure to generate a configure script from the provided configure.ac file? Just run ./autogen.sh, it should do the job. Or get CI build/src from https://builds.smartmontools.org/ Created attachment 229686 [details]
Requested --scan output
Results of "--scan", "--scan-open", and "--scan-open -d megaraid" attached.
Thanks again!
(In reply to Terry Kennedy from comment #19) A few additional comments based on looking at the individual commits... Hinting is working on mrsas: (0:402) new-gate:~terry/smartmontools-master/smartmontools# ./smartctl -a /dev/da0 smartctl 7.3 (build date Nov 23 2021) [FreeBSD 12.2-STABLE amd64] (local build) Copyright (C) 2002-21, Bruce Allen, Christian Franke, www.smartmontools.org Smartctl open device: /dev/da0 failed: DELL or MegaRaid controller, use '-d megaraid,N' In smartctl.8.in, you added "This interface will also work for Dell PERC controllers." The PERC S100 (and perhaps other S-series) are "soft RAID" based on Box Hill. So this probably won't work there. I can fire up a system with that hardware if you'd like me to check things. I'm pretty sure that "... for Dell PERH H-series controllers" is a safe bet. Thank you for testing! What i can also detect if request comes via mrsas driver, this should be safer. But i was not sure if this would not break JBOD configuration. Would be nice if someone can tell if JBOD disks on mrsas are supporting SMART directly or not. P.S. going to backport this to the port today. In case of any additional issues feel free to comment here, open additional PR or just report directly on smartmontools.org A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=40a957b3db989c9d820563005df61464f8a0312d commit 40a957b3db989c9d820563005df61464f8a0312d Author: Oleksii Samorukov <samm@FreeBSD.org> AuthorDate: 2021-11-24 07:15:14 +0000 Commit: Oleksii Samorukov <samm@FreeBSD.org> CommitDate: 2021-11-24 07:28:58 +0000 sysutils/smartmontools: Implement monitoring of the devices behind mrsas RAID PR: 212211 Reported by: stesin@gmail.com sysutils/smartmontools/Makefile | 2 +- .../files/patch-os__freebsd.cpp (new) | 450 +++++++++++++++++++++ .../smartmontools/files/patch-os__freebsd.h (new) | 167 ++++++++ .../smartmontools/files/patch-smartctl.8.in (new) | 47 +++ .../files/patch-smartd.conf.5.in (new) | 56 +++ sysutils/smartmontools/files/smart.in | 3 + 6 files changed, 724 insertions(+), 1 deletion(-) (In reply to Terry Kennedy from comment #20) >I'm pretty sure that "... for Dell PERH H-series controllers" is a safe bet. Typo aside, if it's good for the H-series, it's surely good for the I-series as well; the only difference is that the I-series is blessed for use in the integrated storage controller slot. I updated PERC matching (see r5253, https://www.smartmontools.org/changeset/5253) to match anything with "PERC ". We do not have any such drive in drivedb and in case of soft-raid it will not hurt as they are visible as normal SATA controllers and should not alter any drive info. |
