Bug 215089
| Summary: | [PATCH] graphics/graphviz: Backport patch to make the build work with BSD grep and WITHOUT_GNU_GREP_COMPAT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Raphael Kubo da Costa <rakuco> | ||||
| Component: | Individual Port(s) | Assignee: | Dirk Meyer <dinoex> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dinoex | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | dinoex:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: dinoex Date: Thu Dec 8 20:30:30 UTC 2016 New revision: 428157 URL: https://svnweb.freebsd.org/changeset/ports/428157 Log: - use egrep for portability PR: 215089 Submitted by: Raphael Kubo da Costa Changes: head/graphics/graphviz/files/patch-Makefile.in |
Created attachment 177708 [details] Proposed patch graphviz currently fails to build when base is built with BSD grep and the WITHOUT_GNU_GREP_COMPAT knob is set: the pattern does not match because '|' does not have any special meaning in simple regex mode (ie. when egrep is not used). It works when GNU grep compatibility is enabled because GNU grep allows the same special characters in both simple and extended regex mode. The attached patch backports a pull request I sent upstream switching the call from grep to egrep, which works with all possible grep variations.