Bug 215089 - [PATCH] graphics/graphviz: Backport patch to make the build work with BSD grep and WITHOUT_GNU_GREP_COMPAT
Summary: [PATCH] graphics/graphviz: Backport patch to make the build work with BSD gre...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-12-06 08:16 UTC by Raphael Kubo da Costa
Modified: 2016-12-08 20:48 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+

Attachments
Proposed patch (1.22 KB, patch)
2016-12-06 08:16 UTC, Raphael Kubo da Costa 		rakuco: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-12-06 08:16:21 UTC 
Created attachment 177708 [details]
Proposed patch

graphviz currently fails to build when base is built with BSD grep and the WITHOUT_GNU_GREP_COMPAT knob is set: the pattern does not match because '|' does not have any special meaning in simple regex mode (ie. when egrep is not used). It works when GNU grep compatibility is enabled because GNU grep allows the same special characters in both simple and extended regex mode.

The attached patch backports a pull request I sent upstream switching the call from grep to egrep, which works with all possible grep variations.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-12-08 20:30:37 UTC 
A commit references this bug:

Author: dinoex
Date: Thu Dec  8 20:30:30 UTC 2016
New revision: 428157
URL: https://svnweb.freebsd.org/changeset/ports/428157

Log:
  - use egrep for portability
  PR:		215089
  Submitted by:	Raphael Kubo da Costa

Changes:
  head/graphics/graphviz/files/patch-Makefile.in