Bug 215230
| Summary: | devel/subversion: Fix shebang fix | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Xin LI <delphij> | ||||
| Component: | Individual Port(s) | Assignee: | Lev A. Serebryakov <lev> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | Flags: | bugzilla:
maintainer-feedback?
(lev) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 216309 | ||||||
| Attachments: |
|
||||||
Committed, thanks! A commit references this bug: Author: lev Date: Wed Feb 1 17:42:41 UTC 2017 New revision: 433059 URL: https://svnweb.freebsd.org/changeset/ports/433059 Log: Fix shebang fix for new sed(1) behavior PR: 215230 Submitted by: Xin Li <delphij@FreeBSD.org> Changes: head/devel/subversion/Makefile.common head/devel/subversion18/Makefile.common |
Created attachment 177887 [details] Proposed fix The build would fail on: ===> Patching for subversion-1.9.5 ===> Applying extra patch /usr/ports/devel/subversion/files/extra-patch-fbsd-template ===> Applying FreeBSD patches for subversion-1.9.5 sed: /tmp/usr/ports/devel/subversion/work/subversion-1.9.5/tools/dist/nominate.pl: in-place editing only works for regular files *** Error code 1 The problem is that the port is not using the standard Uses/shebangfix.mk but instead used grep -R, which does not distinguish between regular file and symbolic links. The proposed fix uses find(1) instead of using direct recursive grep.