Summary: | [patch] sysutils/htop does not need python to build | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||||
Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | gaod | ||||||
Priority: | --- | Keywords: | patch | ||||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(gaod) |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Created attachment 178741 [details]
Build log
Build log showing successful build without python.
Hi Adam, You are right. There is no need to invoke python. The patch seems fine, please commit it, thanks. A commit references this bug: Author: adamw Date: Wed Jan 11 14:14:55 UTC 2017 New revision: 431183 URL: https://svnweb.freebsd.org/changeset/ports/431183 Log: Python is never actually used in the build here, so remove the dependency and the associated shebangfix. PR: 215959 Approved by: maintainer (Hung-Yi Chen) Changes: head/sysutils/htop/Makefile Done. Thanks for reviewing so quickly! |
Created attachment 178740 [details] Remove python dependency htop doesn't seem to need python at all to build. Please see the attached log. AFAICT we can just remove the python dependency entirely (as well as the shebangfix).