Bug 216263

Summary: emulators/open-vm-tools emulators/open-vm-tools-nox11: Fix build with clang 4.0.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Some People CC: dim, emaste, jbeich
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (swills)
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 216008    
Attachments:
Description Flags
Disable -Waddress-of-packed-member for open-vm-tools none

Description Dimitry Andric freebsd_committer 2017-01-19 18:47:58 UTC
Created attachment 179077 [details]
Disable -Waddress-of-packed-member for open-vm-tools

In bug 216008, we are testing clang 4.0.0 for ports, and open-vm-tools doesn't compile with it, due to its new -Waddress-of-packed-member warning:

hgfsServer.c:5709:50: error: taking address of packed member 'actualSize' of class or structure 'HgfsReplyReadV3' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
                                                &reply->actualSize);
                                                 ^~~~~~~~~~~~~~~~~
hgfsServer.c:5729:63: error: taking address of packed member 'actualSize' of class or structure 'HgfsReplyRead' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
                                             reply->payload, &reply->actualSize);
                                                              ^~~~~~~~~~~~~~~~~

We could fix this warning by patching the code, but I assume this will be executed on x86 only, so suppressing the warning is less hassle.  Here is a patch to do just that.
Comment 1 Dimitry Andric freebsd_committer 2017-02-04 21:15:59 UTC
*** Bug 216643 has been marked as a duplicate of this bug. ***
Comment 2 Steve Wills freebsd_committer 2017-03-24 18:58:12 UTC
Port is updated, should be fixed.