Description Dimitry Andric 2017-01-19 18:47:58 UTC

Created attachment 179077 [details]
Disable -Waddress-of-packed-member for open-vm-tools

In bug 216008, we are testing clang 4.0.0 for ports, and open-vm-tools doesn't compile with it, due to its new -Waddress-of-packed-member warning:

hgfsServer.c:5709:50: error: taking address of packed member 'actualSize' of class or structure 'HgfsReplyReadV3' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
                                                &reply->actualSize);
                                                 ^~~~~~~~~~~~~~~~~
hgfsServer.c:5729:63: error: taking address of packed member 'actualSize' of class or structure 'HgfsReplyRead' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
                                             reply->payload, &reply->actualSize);
                                                              ^~~~~~~~~~~~~~~~~

We could fix this warning by patching the code, but I assume this will be executed on x86 only, so suppressing the warning is less hassle.  Here is a patch to do just that.