Bug 216317

Summary: net-mgmt/flow-tools: patch to compile with clang
Product: Ports & Packages Reporter: Victor Sudakov <vas>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: bofh, ports, vas
Priority: --- Flags: bugzilla: maintainer-feedback? (bofh)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to remove inline functions
none
use gnu89 mode none

Description Victor Sudakov 2017-01-20 16:37:34 UTC
Created attachment 179142 [details]
Patch to remove inline functions

I suggest a patch which will permit to remove USE_GCC= from the port.
USE_GCC is ugly because it installs many runtime dependencies.
Comment 1 Eugene Grosbein 2017-01-22 08:06:49 UTC
Created attachment 179207 [details]
use gnu89 mode
Comment 2 Eugene Grosbein 2017-01-22 08:07:16 UTC
The problem can be solved simplier with single-line patch switching Clang from its default c99 mode to GCC's default gnu89 mode. The patch is attached.
Comment 3 Victor Sudakov 2017-01-22 08:38:11 UTC
(In reply to Eugene Grosbein from comment #2)
Thanks, your solution is much more correct.
Comment 4 Victor Sudakov 2017-03-05 04:29:29 UTC
Dear Muhammad,

The solution is a one line patch. Why not commit it and move on?
Comment 5 Muhammad Moinur Rahman freebsd_committer 2017-03-05 19:43:19 UTC
(In reply to vas from comment #4)
This has been fixed at revision 433278.
https://svnweb.freebsd.org/ports/head/net-mgmt/flow-tools/Makefile?r1=426566&r2=433278&pathrev=433346