Bug 217540
| Summary: | www/seahub: Updated to 6.0.8 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Ultima <Ultima1252> | ||||
| Component: | Individual Port(s) | Assignee: | Nikolai Lifanov <lifanov> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | lifanov, pi | ||||
| Priority: | --- | Keywords: | easy, patch-ready | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/haiwen/seahub/commits/v6.0.8-pro | ||||||
| Attachments: |
|
||||||
Created attachment 180501 [details]
seahub.diff
forgot to add patchfile xD
Do you mind if I set SEAFILE_VER like this?
SEAFILE_VER!= ${MAKE} -V PORTVERSION -C ${.CURDIR}/../../net-mgmt/seafile-server
This saves a couple of forks and a pipe.
I tested that this is equivalent but expanded immediately and not in patch phase.
An even better optimization would be splitting SEAFILE_VER into Makefile.inc and .include-ing it. I can provide a patch that would do this if you like. Look at aspell, eric6, and doom/quake ports to see what I mean. I'm going to commit this as-is, but please let me know if you want to switch to an include file to share this version between ports. A commit references this bug: Author: lifanov Date: Mon Mar 6 16:21:36 UTC 2017 New revision: 435555 URL: https://svnweb.freebsd.org/changeset/ports/435555 Log: update www/seahub to 6.0.8 Changes: https://github.com/haiwen/seahub/commits/v6.0.8-pro PR: 217540 Submitted by: ultima1252@gmail.com (maintainer) Changes: head/www/seahub/Makefile head/www/seahub/distinfo head/www/seahub/pkg-plist Committed, thanks! (In reply to Nikolai Lifanov from comment #3) ok, thanks for the suggestion ill take a look next weekend. The make alternative is a good suggestion as well. Ill decide then as designed for the task. |
This is an update for seahub to the most current version, 6.0.8. I also regenerated the plist file. * Updated to 6.0.8 * Regenerated plist portlint -AC: WARN: Makefile: [0]: possible direct use of command "file" found. use ${FILE} instead. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. 0 fatal errors and 2 warnings found. poudriere bulk -tC: 12amd64: success https://poudriere.ultimasbox.com/data/12amd64-test/2017-03-04_11h28m57s/logs/seahub-6.0.8.log 12i386: success https://poudriere.ultimasbox.com/data/12i386-test/2017-03-04_11h28m58s/logs/seahub-6.0.8.log 110amd64: success https://poudriere.ultimasbox.com/data/110amd64-test/2017-03-04_11h28m55s/logs/seahub-6.0.8.log 110i386: success https://poudriere.ultimasbox.com/data/110i386-test/2017-03-04_11h28m56s/logs/seahub-6.0.8.log 103amd64: success https://poudriere.ultimasbox.com/data/103amd64-test/2017-03-04_11h28m52s/logs/seahub-6.0.8.log 103i386: success https://poudriere.ultimasbox.com/data/103i386-test/2017-03-04_11h28m53s/logs/seahub-6.0.8.log