Bug 217540 - www/seahub: Updated to 6.0.8
Summary: www/seahub: Updated to 6.0.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nikolai Lifanov
URL: https://github.com/haiwen/seahub/comm...
Keywords: easy, patch-ready
Depends on:
Reported: 2017-03-04 16:59 UTC by Ultima
Modified: 2017-03-06 17:59 UTC (History)
2 users (show)

See Also:

seahub.diff (29.97 KB, patch)
2017-03-04 17:00 UTC, Ultima
Ultima1252: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ultima 2017-03-04 16:59:45 UTC
This is an update for seahub to the most current version, 6.0.8. I also regenerated the plist file.

* Updated to 6.0.8
* Regenerated plist

portlint -AC:
WARN: Makefile: [0]: possible direct use of command "file" found. use ${FILE} instead.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 2 warnings found.

poudriere bulk -tC:
12amd64: success https://poudriere.ultimasbox.com/data/12amd64-test/2017-03-04_11h28m57s/logs/seahub-6.0.8.log
12i386: success https://poudriere.ultimasbox.com/data/12i386-test/2017-03-04_11h28m58s/logs/seahub-6.0.8.log
110amd64: success https://poudriere.ultimasbox.com/data/110amd64-test/2017-03-04_11h28m55s/logs/seahub-6.0.8.log
110i386: success https://poudriere.ultimasbox.com/data/110i386-test/2017-03-04_11h28m56s/logs/seahub-6.0.8.log
103amd64: success https://poudriere.ultimasbox.com/data/103amd64-test/2017-03-04_11h28m52s/logs/seahub-6.0.8.log
103i386: success https://poudriere.ultimasbox.com/data/103i386-test/2017-03-04_11h28m53s/logs/seahub-6.0.8.log
Comment 1 Ultima 2017-03-04 17:00:58 UTC
Created attachment 180501 [details]

forgot to add patchfile xD
Comment 2 Nikolai Lifanov freebsd_committer 2017-03-06 16:06:17 UTC
Do you mind if I set SEAFILE_VER like this?

SEAFILE_VER!=	${MAKE} -V PORTVERSION -C ${.CURDIR}/../../net-mgmt/seafile-server

This saves a couple of forks and a pipe.
I tested that this is equivalent but expanded immediately and not in patch phase.
Comment 3 Nikolai Lifanov freebsd_committer 2017-03-06 16:13:58 UTC
An even better optimization would be splitting SEAFILE_VER into Makefile.inc and .include-ing it. I can provide a patch that would do this if you like.

Look at aspell, eric6, and doom/quake ports to see what I mean.
Comment 4 Nikolai Lifanov freebsd_committer 2017-03-06 16:20:42 UTC
I'm going to commit this as-is, but please let me know if you want to switch to an include file to share this version between ports.
Comment 5 commit-hook freebsd_committer 2017-03-06 16:22:12 UTC
A commit references this bug:

Author: lifanov
Date: Mon Mar  6 16:21:36 UTC 2017
New revision: 435555
URL: https://svnweb.freebsd.org/changeset/ports/435555

  update www/seahub to 6.0.8

   Changes: https://github.com/haiwen/seahub/commits/v6.0.8-pro

  PR:		217540
  Submitted by:	ultima1252@gmail.com (maintainer)

Comment 6 Nikolai Lifanov freebsd_committer 2017-03-06 16:25:04 UTC
Committed, thanks!
Comment 7 Ultima 2017-03-06 17:59:26 UTC
(In reply to Nikolai Lifanov from comment #3)
ok, thanks for the suggestion ill take a look next weekend. The make alternative is a good suggestion as well. Ill decide then as designed for the task.