Bug 219501
| Summary: | net-mgmt/softflowd: update to 0.9.9_1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Paul Godard <paulgodard> | ||||||
| Component: | Individual Port(s) | Assignee: | Jochen Neumeister <joneum> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | jmohacsi, joneum | ||||||
| Priority: | --- | Keywords: | patch-ready | ||||||
| Version: | Latest | Flags: | jmohacsi:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Approved (In reply to Paul Godard from comment #0) Hi Paul, i see, you will delete the patch softflowd.c Can you tell me, why? I test the patch with this port, and it works fine: http://joneumbox.org/data/12amd64-ports/2017-05-26_11h35m46s/logs/softflowd-0.9.9_1.log Hi Jochen, I'm removing the patch file only to clean up the port and because the patch is no longer required. The softflowd.c patch added support for the pflog datalink type; that's no longer required as it's now natively part of softflowd (take a look at the following commit https://github.com/irino/softflowd/commit/b7e50ae4ebb3368a52c7938e1d2b046f90cf6d8f). Thanks, Paul USE_AUTOTOOLS= autoconf USE_AUTOTOOLS= autoheader It is more readable to put these two autotools USES on one line. Or even better, can you convert this to USES=autoreconf and if needed add GNU_CONFIGURE=yes (In reply to Jochen Neumeister from comment #4) I've tested using "USES=autoreconf" as opposed to the two "USE_AUTOTOOLS" directives; I can confirm that this works just fine. Updating diff file to reflect proposed Makefile changes. Created attachment 183040 [details]
softflowd-0.9.9_1.diff
Added "autoreconf" to the "USES" directive and removed the two "USE_AUTOTOOLS" directives as per suggestion
A commit references this bug: Author: joneum Date: Sat Jun 3 18:41:03 UTC 2017 New revision: 442513 URL: https://svnweb.freebsd.org/changeset/ports/442513 Log: - Set USES: autoreconf - Switch to GitHub - Bump PORTREVISION PR: 219501 Reported by: Paul Godard Approved by: jmohacsi@bsd.hu (maintainer) miwi (mentor) Differential Revision: https://reviews.freebsd.org/D10961 Changes: head/net-mgmt/softflowd/Makefile head/net-mgmt/softflowd/distinfo head/net-mgmt/softflowd/files/patch-softflowd.c Committed, thanks :-) |
Created attachment 182861 [details] softflowd-0.9.9_1.diff New port revision (0.9.9_1) - Update to latest 0.9.9 version as found on irino's GitHub repot (the original author of softflowd - Damien Miller - indicated that the current active repo to use should be irino's GitHub repo) - Includes a lot of work by Hitoshi Irino to implement IPFIX - Includes native support for the pflog datalink type (thus no longer needing a FreeBSD specific patch) - Includes single instance checking (multiple instances can execute when using different pid files)