Bug 219569
| Summary: | graphics/enblend: missing png dependency | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Stefan Ehmann <shoesoft> | ||||
| Component: | Individual Port(s) | Assignee: | Greg Lehey <grog> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | mandree, rakuco, tcberner | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(grog) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: mandree Date: Fri Jun 2 20:52:46 UTC 2017 New revision: 442462 URL: https://svnweb.freebsd.org/changeset/ports/442462 Log: Add libpng to LIB_DEPENDS, fixing poudriere builds. This fixes the following poudriere build failure in the configure stage (in a fully patched amd64-based 10.3-RELEASE jail): [...] checking for jpeglib.h... yes checking png.h usability... no checking png.h presence... no checking for png.h... no configure: error: libpng-devel header files are required to compile Enblend. ===> Script "configure" failed unexpectedly. PR: 219569 Reported by: Stefan Ehmann (with different patch) Approved by: portmgr (blanket for trivial and tested fixes) Changes: head/graphics/enblend/Makefile I would suspect that this failure is a regression of a recent change to graphics/vigra, which changed vigra to no longer require PNG by default, so that enblend needs to require PNG explicitly. I doubt the vigra change to waive PNG is good (separate issue though). I suspect that https://svnweb.freebsd.org/ports?view=revision&revision=441331 is the change that exposed this latent defect. (In reply to Matthias Andree from comment #3) You're right, I should have added the new options, that were previously WITHOUT_VIGRA_FOO to options default. I'll do that later. A commit references this bug: Author: tcberner Date: Fri Jun 2 21:20:53 UTC 2017 New revision: 442463 URL: https://svnweb.freebsd.org/changeset/ports/442463 Log: Add more options to OPTIONS_DEFAULT When convertin the WITHOUT_VIGRA_<FOO> flags to options in r441331 I failed to add them to options default. So for example, the dependency on PNG was no longer the default. Add all the options, that were previously flags to OPTIONS_DEFAULT. PR: 219569 Reported by: mandree Changes: head/graphics/vigra/Makefile |
Created attachment 182931 [details] patch to add png dependency I get the following error when building enblend with today's ports in poudriere: checking for jpeglib.h... yes checking png.h usability... no checking png.h presence... no checking for png.h... no configure: error: libpng-devel header files are required to compile Enblend. ===> Script "configure" failed unexpectedly. Adding the dependency fixes the build for me - see attached patch.