Bug 219569 - graphics/enblend: missing png dependency
Summary: graphics/enblend: missing png dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Greg Lehey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-26 12:41 UTC by Stefan Ehmann
Modified: 2017-06-02 21:21 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (grog)


Attachments
patch to add png dependency (443 bytes, patch)
2017-05-26 12:41 UTC, Stefan Ehmann
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Ehmann 2017-05-26 12:41:11 UTC
Created attachment 182931 [details]
patch to add png dependency

I get the following error when building enblend with today's ports in poudriere:

checking for jpeglib.h... yes
checking png.h usability... no
checking png.h presence... no
checking for png.h... no
configure: error: libpng-devel header files are required to compile Enblend.
===>  Script "configure" failed unexpectedly.

Adding the dependency fixes the build for me - see attached patch.
Comment 1 commit-hook freebsd_committer 2017-06-02 20:53:12 UTC
A commit references this bug:

Author: mandree
Date: Fri Jun  2 20:52:46 UTC 2017
New revision: 442462
URL: https://svnweb.freebsd.org/changeset/ports/442462

Log:
  Add libpng to LIB_DEPENDS, fixing poudriere builds.

  This fixes the following poudriere build failure in the configure stage
  (in a fully patched amd64-based 10.3-RELEASE jail):

  [...]
  checking for jpeglib.h... yes
  checking png.h usability... no
  checking png.h presence... no
  checking for png.h... no
  configure: error: libpng-devel header files are required to compile Enblend.
  ===>  Script "configure" failed unexpectedly.

  PR:		219569
  Reported by:	Stefan Ehmann (with different patch)
  Approved by:	portmgr (blanket for trivial and tested fixes)

Changes:
  head/graphics/enblend/Makefile
Comment 2 Matthias Andree freebsd_committer 2017-06-02 21:05:20 UTC
I would suspect that this failure is a regression of a recent change to graphics/vigra, which changed vigra to no longer require PNG by default, so that enblend needs to require PNG explicitly.  

I doubt the vigra change to waive PNG is good (separate issue though).
Comment 3 Matthias Andree freebsd_committer 2017-06-02 21:08:11 UTC
I suspect that https://svnweb.freebsd.org/ports?view=revision&revision=441331 is the change that exposed this latent defect.
Comment 4 Tobias C. Berner freebsd_committer 2017-06-02 21:11:06 UTC
(In reply to Matthias Andree from comment #3)
You're right, I should have added the new options, that were previously WITHOUT_VIGRA_FOO to options default.

I'll do that later.
Comment 5 commit-hook freebsd_committer 2017-06-02 21:21:40 UTC
A commit references this bug:

Author: tcberner
Date: Fri Jun  2 21:20:53 UTC 2017
New revision: 442463
URL: https://svnweb.freebsd.org/changeset/ports/442463

Log:
  Add more options to OPTIONS_DEFAULT

  When convertin the WITHOUT_VIGRA_<FOO> flags to options in r441331 I failed to
  add them to options default. So for example, the dependency on PNG was no longer
  the default.

  Add all the options, that were previously flags to OPTIONS_DEFAULT.

  PR:		219569
  Reported by:	mandree

Changes:
  head/graphics/vigra/Makefile