Summary: | math/pari: Added USES=readline, fixed X11 detection, added threading options | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||||||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Only Me | ||||||||||||||
Priority: | --- | ||||||||||||||
Version: | Latest | ||||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
Attachments: |
|
Will add more to the patch Created attachment 182974 [details]
patch
Additionally:
4. Added threading support options PTHREADS and MPI
5. Added test targets when supported
Ready to be committed. According to bsd.options.mk, OPTIONS_RADIO is the list of radio-choice grouped options (0 or 1 among N). What if the user chose none of the THREADS options (PTHREADS, MPI and NOTHREADS)? IMHO, "NOTHREADS_DESC=Single threaded" looks strange. Created attachment 182975 [details] patch (In reply to Po-Chuan Hsieh from comment #4) You are right, I removed the NOTHREADS option. Created attachment 182977 [details]
patch
I see %%NOTHREADS%% in pkg-plist. Created attachment 183037 [details]
patch
Thanks for noticing this!
I updated the patch.
The option MPI=on has a caveat that pari fails to build with MPI=on when pari is already installed with PTHREADS=on or MPI=on. I reported this problem upstream. A commit references this bug: Author: sunpoet Date: Mon May 29 17:24:23 UTC 2017 New revision: 442028 URL: https://svnweb.freebsd.org/changeset/ports/442028 Log: Add threading support - Add USES=readline - Add PTHREADS and MPI options - Fix "-lX11 not found" warning - Add test targets - Bump PORTREVISION for dependency and package change PR: 219597 Submitted by: Yuri Victorovich <yuri@rawbw.com> (maintainer) Changes: head/math/pari/Makefile head/math/pari/files/ head/math/pari/files/patch-Configure Committed. Thanks! |
Created attachment 182969 [details] patch The attached patch: 1. Adds USES=readline 2. Fixes warnings that -lX11 isn't found 3. Bumps PORTREVISION