Bug 219597 - math/pari: Added USES=readline, fixed X11 detection, added threading options
Summary: math/pari: Added USES=readline, fixed X11 detection, added threading options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-27 14:07 UTC by Yuri Victorovich
Modified: 2017-05-29 18:00 UTC (History)
0 users

See Also:

Attachments
patch (1.09 KB, patch)
2017-05-27 14:07 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (3.19 KB, patch)
2017-05-27 20:46 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (3.15 KB, patch)
2017-05-27 21:42 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (3.15 KB, patch)
2017-05-27 22:01 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (3.50 KB, patch)
2017-05-29 15:51 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-05-27 14:07:32 UTC 
Created attachment 182969 [details]
patch

The attached patch:
1. Adds USES=readline
2. Fixes warnings that -lX11 isn't found
3. Bumps PORTREVISION
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-27 17:03:41 UTC 
Will add more to the patch
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-27 20:46:56 UTC 
Created attachment 182974 [details]
patch

Additionally:
4. Added threading support options PTHREADS and MPI
5. Added test targets when supported
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-27 20:47:18 UTC 
Ready to be committed.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-05-27 20:56:01 UTC 
According to bsd.options.mk, OPTIONS_RADIO is the list of radio-choice grouped options (0 or 1 among N). What if the user chose none of the THREADS options (PTHREADS, MPI and NOTHREADS)?

IMHO, "NOTHREADS_DESC=Single threaded" looks strange.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-27 21:42:20 UTC 
Created attachment 182975 [details]
patch

(In reply to Po-Chuan Hsieh from comment #4)

You are right, I removed the NOTHREADS option.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-27 22:01:27 UTC 
Created attachment 182977 [details]
patch
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-05-28 01:28:44 UTC 
I see %%NOTHREADS%% in pkg-plist.
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-29 15:51:01 UTC 
Created attachment 183037 [details]
patch

Thanks for noticing this!
I updated the patch.
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2017-05-29 15:53:38 UTC 
The option MPI=on has a caveat that pari fails to build with MPI=on when pari is already installed with PTHREADS=on or MPI=on.
I reported this problem upstream.
Comment 10 commit-hook freebsd_committer freebsd_triage 2017-05-29 17:24:42 UTC 
A commit references this bug:

Author: sunpoet
Date: Mon May 29 17:24:23 UTC 2017
New revision: 442028
URL: https://svnweb.freebsd.org/changeset/ports/442028

Log:
  Add threading support

  - Add USES=readline
  - Add PTHREADS and MPI options
  - Fix "-lX11 not found" warning
  - Add test targets
  - Bump PORTREVISION for dependency and package change

  PR:		219597
  Submitted by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)

Changes:
  head/math/pari/Makefile
  head/math/pari/files/
  head/math/pari/files/patch-Configure
Comment 11 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-05-29 18:00:37 UTC 
Committed. Thanks!