Summary: | Try to handle man files for USE_PYTHON=concurrent | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Fukang Chen <loader> | ||||||||||
Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | koobs, loader, ports-bugs, python | ||||||||||
Priority: | --- | Flags: | antoine:
exp-run+
|
||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
I think locking it to man pages is a bad idea. It should be more generic, something along the lines of a *_WITH_SUFFIX variable or *_WITH_EXT or something. Created attachment 184080 [details]
minor update
example:
UNIQUE_SUFFIX_TYPES+= SUFFIX_MAN
UNIQUE_SUFFIX_MAN_FILES= man/man1/command.1 man/man3/lib.3
UNIQUE_SUFFIX_MAN_WITH_EXT= .[1-9]
they would be renamed to
man/man1/command${UNIQUE_SUFFIX}.1
man/man3/lib${UNIQUE_SUFFIX}.3
Created attachment 188715 [details]
patch
I expect problems with at least 2 ports: - mail/py-pymailq - math/py-numpy Can you provide patch for them? Sure, testing. Created attachment 188835 [details]
v2
fix those two ports.
Thanks mat@ and antoine@ :) Exp-run looks fine. A commit references this bug: Author: mat Date: Tue Dec 19 16:23:49 UTC 2017 New revision: 456737 URL: https://svnweb.freebsd.org/changeset/ports/456737 Log: Enhance USES=uniquefiles to be more generic. This allows to have more complex renaming schemes. Until now, it could only add a prefix or a suffix, but this was not working at all for man pages, because it would give man/man1/pyfoo.1.gz-2.7 or man/man1/pyfoo-1-2.7.gz. With this change, a man page will be correctly renamed to man/man1/pyfoo-2.7.1.gz. Unfix ports that were already handling man pages. PR: 220214 Submitted by: Fukang Chen (previous patch) Exp-run by: antoine Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D13444 Changes: head/Mk/Uses/python.mk head/Mk/Uses/uniquefiles.mk head/mail/py-pymailq/Makefile head/math/py-numpy/Makefile head/math/py-numpy/pkg-plist head/www/py-ddgr/Makefile head/www/py-ddgr/files/patch-Makefile |
Created attachment 183717 [details] install man unique files I'm not proposing this patch, just a thought.