Summary: | security/py-certbot: missing dependency on py-mock | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Randy Westlund <rwestlun> | ||||||
Component: | Individual Port(s) | Assignee: | Carlos J. Puga Medina <cpm> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | cpm | ||||||
Priority: | --- | Keywords: | patch, patch-ready | ||||||
Version: | Latest | Flags: | koobs:
maintainer-feedback+
cpm: maintainer-feedback+ koobs: merge-quarterly? |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://reviews.freebsd.org/D10612 | ||||||||
Attachments: |
|
Description
Randy Westlund
2017-06-26 04:31:11 UTC
mock needs to be patched out of install_requires Created attachment 183803 [details]
patch
- Move py-mock requirement to dev_extras in setup.py
Comment on attachment 183803 [details]
patch
@Carlos I believe we need a PORTREVISION bump here.
Otherwise approved
Is the quarterly version affected? (mock listed in install_requires but not in RUN_DEPENDS?)
Created attachment 183807 [details]
patch
- Bump PORTREVISION
(In reply to Kubilay Kocak from comment #3) MFH to 2017Q2 is required. https://svnweb.freebsd.org/ports/branches/2017Q2/security/py-certbot/Makefile?revision=437407&view=markup#l31 A commit references this bug: Author: cpm Date: Mon Jun 26 11:56:17 UTC 2017 New revision: 444364 URL: https://svnweb.freebsd.org/changeset/ports/444364 Log: security/py-{acme,certbot}: fix missing dependency on py-mock Common: - Move py-mock requirement to dev_extras in setup.py - Bump PORTREVISION PR: 220274 Submitted by: cpm Reported by: Randy Westlund <rwestlun@gmail.com> Approved by: koobs (maintainer, py-certbot) MFH: 2017Q2 Changes: head/security/py-acme/Makefile head/security/py-acme/files/ head/security/py-acme/files/patch-setup.py head/security/py-certbot/Makefile head/security/py-certbot/files/ head/security/py-certbot/files/patch-setup.py (In reply to Carlos J. Puga Medina from comment #5) mock is listed in RUN_DEPENDS (in 2016Q2) ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock That means MFH is not required, or am i missing something? (In reply to Kubilay Kocak from comment #7) I think it would be better to update to 0.15.0 on the quarterly branch. A commit references this bug: Author: cpm Date: Wed Jun 28 16:56:17 UTC 2017 New revision: 444601 URL: https://svnweb.freebsd.org/changeset/ports/444601 Log: MFH: r444364 security/py-{acme,certbot}: fix missing dependency on py-mock Common: - Move py-mock requirement to dev_extras in setup.py - Bump PORTREVISION PR: 220274 Submitted by: cpm Reported by: Randy Westlund <rwestlun@gmail.com> Approved by: koobs (maintainer, py-certbot) Approved by: ports-secteam (miwi) Changes: _U branches/2017Q2/ branches/2017Q2/security/py-acme/Makefile branches/2017Q2/security/py-acme/files/ branches/2017Q2/security/py-certbot/Makefile branches/2017Q2/security/py-certbot/files/ Committed! Thanks |