Bug 220281

Summary: Mk/bsd.default-versions.mk: Set Lua 5.4 as default
Product: Ports & Packages Reporter: Dani I. <i.dani>
Component: Ports FrameworkAssignee: Tobias C. Berner <tcberner>
Status: Closed FIXED    
Severity: Affects Many People CC: fluffy, kevans, portmgr, ports-bugs, russ.haley, tcberner, vvd
Priority: --- Flags: i.dani: maintainer-feedback? (portmgr)
antoine: exp-run+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to update default version of Lua to 5.3 with UPDATING none

Description Dani I. 2017-06-26 10:12:47 UTC
Created attachment 183802 [details]
Patch to update default version of Lua to 5.3 with UPDATING

Lua 5.2 has last been update on the 07 Mar 2015, while Lua 5.3.0 has been released on 12 Jan 2015. The latest release is 5.3.4, which has been released on 30 Jan 2017. See here [1]. There will be no further releases of Lua 5.2. 

There is also sosme new stuff with Lua 5.3. Full changelog from 5.2 to 5.3 can be found here [2]. Breaking changes can be found here [3].

Thanks for taking a look at it.

[1] http://www.lua.org/versions.html
[2] http://www.lua.org/manual/5.3/readme.html#changes
[3] http://www.lua.org/manual/5.3/manual.html#8
Comment 1 Dani I. 2017-06-26 10:14:46 UTC
Additional info: Lua 5.2[1] is without a maintainer, while 5.3[2] has an active maintainer. This should be considered too.

[1] https://www.freshports.org/lang/lua52
[2] https://www.freshports.org/lang/lua53
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2017-06-27 21:41:34 UTC
New failures on 11.0 amd64:


http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/lua53-lzlib-0.4.3.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/celestia-glut-1.6.1_9.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/celestia-gnome-1.6.1_9.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/celestia-gtk-1.6.1_9.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/lua53-alien-0.7.0.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/fxite-0.92_4.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/neovim-0.2.0.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/wordgrinder-0.6.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/mmex-1.2.7_4.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/lua-ada-1.0_1.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/opendkim-2.10.3_6.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/cclive-0.7.16_3.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/quvi-0.4.2_3.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/freeswitch-1.6.13_3.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/lua53-lualdap-1.1.0_2.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/cardpeek-0.8.4.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/syslog-ng-incubator-0.4.1_3.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/lua53-luaexpat-1.3.0_2.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/httest-2.4.19.log
http://package22.nyi.freebsd.org/data/110amd64-default-PR220281/2017-06-27_08h46m05s/logs/volta-0.3.0_1.log

Around 70 ports were skipped due to those failures.
Comment 3 Russell Haley 2017-12-31 04:57:51 UTC
Hi, I have some cliff notes on the failures. 
My thoughts are to set all items in #1 to be 5.2 dependent (assuming such things are possible) and try patching #2 as they should all be easy fixes (to find the next possible failures). Items in #3 are more nuanced. I think 3.1 should be set to 5.2 dependent as well. That to me would would be a first step and then perhaps request another exp-run?


1) 5.2 Dependent systems: 7
Failures seem to be genuine dependencies on 5.2. Some have stated dependencies. Others... I'm not terribly familiar with the Lua C API but the failures are missing/wrong functions during compilation (which suggests an API change).

mmex,lua-ada, openkdm, cclive, quvi, cardpeek, httest

2) Missing lua.h files (misconfigured builds?): 3

Celestia (only checked first Celestia package), freeswitch, volta

3) Others

3.1) lzlib 
	No longer maintainted. 
	Replacement may be:
	https://luarocks.org/modules/brimworks/lua-zlib

	Where is the source for lzlib coming from? I'm not sure what this means:
	MASTER_SITES=	SAVANNAH/lzip/lzlib

3.2) lua-alien
	Configure step fails. Latest from Github has different configure script. Update to use latest from github?

	notes:I checked the configure script in the work directory and upon patching it the compilation starts and fails later.
	I downloaded the latest from github and ran boostrap and checked the configure scipt. configure has been *changed* and no longer performs the check the same way, but notably checks for lua < 5.4

3.3) neovim
	Requires lpeg but the dependency doesn't seem to be explicitly stated

3.4) wordgrinder
	Dependency on 5.2 in the configuration step. It might build if patched?
	=======================<phase: run-depends    >============================
	===>   wordgrinder-0.6 depends on file: /usr/local/lib/lua/5.2/lfs.so - not found
	===>   Installing existing package /packages/All/lua53-luafilesystem-1.6.3.txz
	[110amd64-default-PR220281-job-15] Installing lua53-luafilesystem-1.6.3...
	[110amd64-default-PR220281-job-15] `-- Installing lua53-5.3.4...
	[110amd64-default-PR220281-job-15] `-- Extracting lua53-5.3.4: ......... done
	[110amd64-default-PR220281-job-15] Extracting lua53-luafilesystem-1.6.3: .......... done
	===>   wordgrinder-0.6 depends on file: /usr/local/lib/lua/5.2/lfs.so - not found


3.5) lua-ldap
	Not sure about this one...

	gmake[1]: Entering directory '/wrkdirs/usr/ports/net/lualdap/work/lualdap-1.1.0'
	cc -O2 -Wall -fPIC -W -Waggregate-return -Wcast-align -Wmissing-prototypes -Wnested-externs -Wshadow -Wwrite-strings -ansi -I/usr/local/include/lua53 -I/usr/local/include -I../compat/src -I/usr/local/include/  -c -o src/lualdap.o src/lualdap.c
	In file included from src/lualdap.c:23:
	In file included from /usr/local/include/lua53/lua.h:16:
	/usr/local/include/lua53/luaconf.h:581:2: error: "Compiler does not support 'long long'. Use option '-DLUA_32BITS'   or '-DLUA_C89_NUMBERS' (see file 'luaconf.h' for details)"
	#error "Compiler does not support 'long long'. Use option '-DLUA_32BITS' \
	 ^
	In file included from src/lualdap.c:23:
	/usr/local/include/lua53/lua.h:93:9: error: unknown type name 'LUA_INTEGER'
	typedef LUA_INTEGER lua_Integer;
			^
	/usr/local/include/lua53/lua.h:96:21: error: expected ';' after top level declarator
	typedef LUA_UNSIGNED lua_Unsigned;
						^
						;
	3 errors generated.
	gmake[1]: *** [<builtin>: src/lualdap.o] Error 1
	gmake[1]: Leaving directory '/wrkdirs/usr/ports/net/lualdap/work/lualdap-1.1.0'
	*** Error code 1

3.6) syslogng
	syslog-ng checks for lua in it's configuration, fails to find it but proceeds to try and package the liblua.so file. This port doesn't seem 
	to be correctly configured to use lua on FreeBSD.

	syslog-ng Incubator 0.4.1 configured
	------------------------------------
	 Debugging:            no
	 Modules:
	  basicfuncs-plus      yes
	  kafka                no
	  logmongource:        no
	  lua:                 no 
	  monitor-source:      no 
	  perl:                yes
	  python:              yes (python-2.7)
	  rss                  yes
	  trigger-source       yes
	  tfgetent             yes
	  zmq                  no
	  grok-parser          no
	  java                 no

	===========================================================================
	=======================<phase: build          >============================
	...


	====> Compressing man pages (compress-man)
	===========================================================================
	=======================<phase: package        >============================
	===>  Building package for syslog-ng-incubator-0.4.1_3
	pkg-static: Unable to access file /wrkdirs/usr/ports/sysutils/syslog-ng-incubator/work/stage/usr/local/lib/syslog-ng/liblua.a:No such file or directory
	pkg-static: Unable to access file /wrkdirs/usr/ports/sysutils/syslog-ng-incubator/work/stage/usr/local/lib/syslog-ng/liblua.so:No such file or directory
	pkg-static: Unable to access file /wrkdirs/usr/ports/sysutils/syslog-ng-incubator/work/stage/usr/local/lib/syslog-ng/libmonitor-source.a:No such file or directory
	pkg-static: Unable to access file /wrkdirs/usr/ports/sysutils/syslog-ng-incubator/work/stage/usr/local/lib/syslog-ng/libmonitor-source.so:No such file or directory
	*** Error code 1

	Stop.
	make: stopped in /usr/ports/sysutils/syslog-ng-incubator
	====>> Cleaning up wrkdir
	===>  Cleaning for syslog-ng-incubator-0.4.1_3
	build of sysutils/syslog-ng-incubator ended at Tue Jun 27 09:41:55 UTC 2017
	build time: 00:00:31
	!!! build failure encountered !!!


3.7) luaexpat
	Another long long fail?

	===>  Building for lua53-luaexpat-1.3.0_2
	gmake[1]: Entering directory '/wrkdirs/usr/ports/textproc/luaexpat/work/luaexpat-1.3.0'
	export MACOSX_DEPLOYMENT_TARGET="10.3";
	cc -I/usr/local/include/lua53 -I/usr/local/include -g -pedantic -Wall -O2 -fPIC -DPIC -ansi -O2 -pipe  -DLUA_INT_LONG -fPIC -fstack-protector -fno-strict-aliasing -o src/lxp.so src/lxplib.c -shared -lexpat  -L/usr/local/lib -fstack-protector
	In file included from src/lxplib.c:14:
	In file included from /usr/local/include/lua53/lua.h:16:
	/usr/local/include/lua53/luaconf.h:110:9: warning: 'LUA_INT_LONG' macro redefined [-Wmacro-redefined]
	#define LUA_INT_LONG            2
			^
	<command line>:2:9: note: previous definition is here
	#define LUA_INT_LONG 1
Comment 4 Dima Panov freebsd_committer freebsd_triage 2018-01-08 16:55:41 UTC
(In reply to Russell Haley from comment #3)

For 3.7 luaexpat — PR 224644 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224644) is already opened, waiting for maintaner[-timeout?]
Comment 5 Dima Panov freebsd_committer freebsd_triage 2018-01-08 16:58:02 UTC
(In reply to Russell Haley from comment #3)

3.5 lua-ldap should be fixed same way as luaexpat
Comment 6 Dima Panov freebsd_committer freebsd_triage 2018-01-14 06:31:50 UTC
JFYI - fix for luaexpat was committed
Comment 7 Adam Weinberger freebsd_committer freebsd_triage 2018-08-18 15:46:02 UTC
neovim builds against lua53 with no problem now.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2019-07-30 10:25:08 UTC
Patch for net/freeswitch:

--- net/freeswitch/Makefile.orig
+++ net/freeswitch/Makefile
@@ -39,7 +39,7 @@
 GNU_CONFIGURE=         yes
 CONFIGURE_ARGS=        --with-pkgconfigdir=${PREFIX}/libdata/pkgconfig \
                --enable-zrtp
-CFLAGS+=       -Wno-error
+CFLAGS+=       -Wno-error -I${LUA_INCDIR}
 
 USERS=         ${PORTNAME}
 GROUPS=                ${USERS}
Comment 9 Russell Haley 2020-04-17 04:13:37 UTC
There is work being done over here: https://reviews.freebsd.org/D14709
and here: 
https://reviews.freebsd.org/D16494
Comment 10 Kyle Evans freebsd_committer freebsd_triage 2020-10-25 17:31:31 UTC
(In reply to Russell Haley from comment #9)

Should this be revisited now that flavors has landed?
Comment 13 Tobias C. Berner freebsd_committer freebsd_triage 2022-09-07 16:26:03 UTC
(In reply to Antoine Brodin from comment #12)
@antoine,

Should we try and take this for a re-run with 5.4 as the default?


mfg Tobias
Comment 14 Antoine Brodin freebsd_committer freebsd_triage 2022-09-07 16:27:33 UTC
(In reply to Tobias C. Berner from comment #13)
If no one fixes the fallout, no.
Comment 15 Tobias C. Berner freebsd_committer freebsd_triage 2022-09-08 06:48:12 UTC
(In reply to Antoine Brodin from comment #14)
Moin moin 

I ran a
> poudriere bulk [...] $(portgrep -u lua -R . -s -1)   

Failed ports: 
 * editors/wordgrinder:build 
 * graphics/dcmtk:build 
 * databases/luadbi@lua51:build
 * lang/py-lupa@py311:build 
 * databases/luadbi@lua54:build
 * games/openra:build_fs_violation 
 * www/httest:build
 * databases/luadbi@lua52:build
 * databases/luadbi@lua53:build
 * games/jaggedalliance2:build/runaway

So I think the only thing that needs fixgin is the lua-version check in www/httest...
Comment 16 Tobias C. Berner freebsd_committer freebsd_triage 2022-09-08 06:57:55 UTC
(In reply to Tobias C. Berner from comment #15)
Or the port could be marked as just not working with lua-5.3 -- it seems rather dead upstream.
Comment 17 commit-hook freebsd_committer freebsd_triage 2022-09-08 07:52:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=834e273d0233cd36a48d11a0b8dfc3c1331b4ff1

commit 834e273d0233cd36a48d11a0b8dfc3c1331b4ff1
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-08 07:50:55 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-08 07:51:35 +0000

    www/httest: enable only for lua <= 5.2

    From lua_module.c:
      #if ( LUA_VERSION_NUM == 501 )
        failed = (lua_load(L, lua_get_line, reader, "@client") != 0 ||
                  lua_pcall(L, 0, LUA_MULTRET, 0) != 0);
      #elif ( LUA_VERSION_NUM  == 502 )
        failed = (lua_load(L, lua_get_line, reader, "@client", NULL) != 0 ||
                  lua_pcall(L, 0, LUA_MULTRET, 0) != 0);
      #else
        #error this lua version is not supported
      #endif

    PR:             220281

 www/httest/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 18 Tobias C. Berner freebsd_committer freebsd_triage 2022-09-08 08:46:53 UTC
(In reply to commit-hook from comment #17)
@antoine, could you please re-run it?
Comment 19 Antoine Brodin freebsd_committer freebsd_triage 2022-09-18 18:47:49 UTC
bulk -a fails to start with 5.4 as default:

[00:01:17] Error: compute_deps_pkg failed to lookup pkgname for devel/lua-lgi@lua54 processing package awesome-4.3_3,1 from x11-wm/awesome -- Is SUBDIR+=lua-lgi@lua54 missing in devel/Makefile and does the port provide the 'lua54' FLAVOR?
Comment 20 Antoine Brodin freebsd_committer freebsd_triage 2022-09-18 18:52:50 UTC
I will try with this:


diff --git a/Mk/bsd.default-versions.mk b/Mk/bsd.default-versions.mk
index 4928947084..4aafa204ce 100644
--- a/Mk/bsd.default-versions.mk
+++ b/Mk/bsd.default-versions.mk
@@ -85,7 +85,7 @@ LLVM_DEFAULT?=                10
 LLVM_DEFAULT?=         90
 .  endif
 # Possible values: 5.1, 5.2, 5.3, 5.4
-LUA_DEFAULT?=          5.2
+LUA_DEFAULT?=          5.4
 # Possible values: 5.10, 5.20, 6.8
 MONO_DEFAULT=          5.10
 # Possible values: 5.6, 5.7, 8.0, 10.3m, 10.4m, 10.5m, 5.7p, 5.7w
diff --git a/x11-wm/awesome/Makefile b/x11-wm/awesome/Makefile
index a9224658df..2bb2fb667a 100644
--- a/x11-wm/awesome/Makefile
+++ b/x11-wm/awesome/Makefile
@@ -27,7 +27,7 @@ LIB_DEPENDS=  libcairo.so:graphics/cairo \

 CONFLICTS_INSTALL=     awesome3

-USES=          cmake compiler:c11 gettext gnome iconv magick:build pkgconfig lua \
+USES=          cmake compiler:c11 gettext gnome iconv magick:build pkgconfig lua:53 \
                shebangfix xorg
 USE_GNOME=     glib20 pango gdkpixbuf2 librsvg2
 USE_XORG=      pixman x11 xau xcb xdmcp xext xft xinerama xrandr xrender \
Comment 23 commit-hook freebsd_committer freebsd_triage 2022-09-24 05:26:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=62148c8e7e0bb4227942b7df109fbf7ca44a7420

commit 62148c8e7e0bb4227942b7df109fbf7ca44a7420
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 05:24:24 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 05:24:24 +0000

    devel/lua-lgi: add support for lua 5.4

    PR:             220281

 devel/lua-lgi/Makefile | 5 ++++-
 devel/lua-lgi/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)
Comment 24 commit-hook freebsd_committer freebsd_triage 2022-09-24 06:35:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4a25b3f82280ef76f0295f1e2daa828bf8fd7cd

commit b4a25b3f82280ef76f0295f1e2daa828bf8fd7cd
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 06:26:45 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 06:26:45 +0000

    net/freeswitch: restrict to lua <= 5.3

    The configure script checks for lua-5.3, lua-5.2...

    PR:             220281

 net/freeswitch/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 25 commit-hook freebsd_committer freebsd_triage 2022-09-24 06:35:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c61262ea1cf7688c41929400d0cd9c7c20e69b93

commit c61262ea1cf7688c41929400d0cd9c7c20e69b93
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 06:24:42 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 06:25:01 +0000

    games/freedroidrpg: restrict support to lua <= 5.3

    Used function calls to lua_resume are not 5.4 ready.

    PR:             220281

 games/freedroidrpg/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 26 commit-hook freebsd_committer freebsd_triage 2022-09-24 06:35:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37be1981be3413e7b688de9274f35c777e029829

commit 37be1981be3413e7b688de9274f35c777e029829
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 06:18:25 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 06:18:25 +0000

    archivers/urbackup-server: remove bogus lua >= 5.3 support

    The configure script looks for lua-5.3, lua-5.2...

    PR:             220281

 archivers/urbackup-server/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 27 commit-hook freebsd_committer freebsd_triage 2022-09-24 06:35:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ea13e3160369b33e49c84b3113a39aa5c193b5a

commit 1ea13e3160369b33e49c84b3113a39aa5c193b5a
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 05:36:54 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 06:05:48 +0000

    x11-wm/awesome: restrict to lua<=5.3

    Upstream already merged support for lua-5.4, so the added restriction
    can be removed once awesome gets a new release.

    PR:             220281

 x11-wm/awesome/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 28 commit-hook freebsd_committer freebsd_triage 2022-09-24 06:35:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=353fe84edc206e07994113f8f9d2e3945134329f

commit 353fe84edc206e07994113f8f9d2e3945134329f
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 06:14:04 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 06:14:04 +0000

    x11-toolkits/termit: remove bogus lua >= 5.3 support

    The Cmake code used in the project explicitely requires lua 5.3.

    PR:             220281

 x11-toolkits/termit/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 29 commit-hook freebsd_committer freebsd_triage 2022-09-24 06:35:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=33e059ba8d8c7bd97c44a85ba9b8bee56d6e9779

commit 33e059ba8d8c7bd97c44a85ba9b8bee56d6e9779
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-24 06:03:56 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-24 06:05:53 +0000

    sysutils/lsyncd: restrict to lua <= 5.3

    Upstream already added support for lua 5.4 -- so this restriction
    can be removed in the next update.

    PR:             220281

 sysutils/lsyncd/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 30 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-06 07:50:51 UTC
(In reply to commit-hook from comment #29)

@antoine, the mentionned fallout has been fixed, was there anymore?

mfg Tobias
Comment 32 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-09 11:34:16 UTC
(In reply to Antoine Brodin from comment #31)
OK, I'll take a look.
Comment 33 commit-hook freebsd_committer freebsd_triage 2022-12-10 08:56:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f11a130a7c35ee076d16c6a5881af8bb29ba8c19

commit f11a130a7c35ee076d16c6a5881af8bb29ba8c19
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-10 08:54:07 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-10 08:54:54 +0000

    security/lua-bcrypt: depend on flavored luarocks

    PR:             220281

 security/lua-bcrypt/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 34 commit-hook freebsd_committer freebsd_triage 2022-12-10 08:56:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=541ae71a04fef1d0bc8f04037d28e9ea4e1174dd

commit 541ae71a04fef1d0bc8f04037d28e9ea4e1174dd
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-10 08:46:37 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-10 08:54:42 +0000

    net/lualdap: fix build for lua54 flavor

    PR:             220281

 net/lualdap/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 35 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-10 08:57:04 UTC
(In reply to Antoine Brodin from comment #31)
fixed :)
Comment 36 Antoine Brodin freebsd_committer freebsd_triage 2022-12-10 09:24:54 UTC
ok this should be fine
Comment 37 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-10 09:33:51 UTC
Committed, thanks for the exp-run :)
Comment 38 commit-hook freebsd_committer freebsd_triage 2022-12-10 09:34:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=749a79b5fe276e0efd3539fffeeda5ccba9f2e7f

commit 749a79b5fe276e0efd3539fffeeda5ccba9f2e7f
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-10 09:32:27 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-10 09:32:27 +0000

    Mk/bsd.default-versions.mk: set Lua 5.4 as the default

    PR:             220281
    Exp-run by:     antoine

 Mk/bsd.default-versions.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)