Bug 224644 - textproc/luaexpat: use proper INT definition, unbreak with lua53 right way
Summary: textproc/luaexpat: use proper INT definition, unbreak with lua53 right way
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: David Thiel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-28 14:46 UTC by Dima Panov
Modified: 2018-01-12 23:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (lx)


Attachments
Unbreak with lua53 right way (577 bytes, patch)
2017-12-28 14:46 UTC, Dima Panov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer 2017-12-28 14:46:03 UTC
Created attachment 189165 [details]
Unbreak with lua53 right way

Currently luaexpat fails to build against lua53 due to incorrect INT definition, LUA_INT_LONG doesn't affect at all int/long variations. 
But LUA_32BITS do it right way, and widely used in other lua-based ports
Comment 1 David Thiel freebsd_committer 2018-01-11 20:33:35 UTC
Does this still play nice with Lua 5.1?
Comment 2 Dima Panov freebsd_committer 2018-01-12 01:19:28 UTC
(In reply to David Thiel from comment #1)
Yes, this solution works with lua51 too. 
AFAIR, most distros build 3dparty lua components with LUA_32BITS
Comment 3 commit-hook freebsd_committer 2018-01-12 21:49:10 UTC
A commit references this bug:

Author: lx
Date: Fri Jan 12 21:48:52 UTC 2018
New revision: 458877
URL: https://svnweb.freebsd.org/changeset/ports/458877

Log:
  Correctly unbreak with lua53.

  PR:		224644
  Submitted by:	fluffy

Changes:
  head/textproc/luaexpat/Makefile
Comment 4 David Thiel freebsd_committer 2018-01-12 23:06:38 UTC
Committed, thanks!