Bug 221237

Summary: lang/gcc5: caches system header files in 2017Q3, affecting multimedia/handbrake
Product: Ports & Packages Reporter: Mason Loring Bliss <mason>
Component: Individual Port(s)Assignee: Gerald Pfeifer <gerald>
Status: Closed FIXED    
Severity: Affects Some People CC: admin, gerald, ports-secteam
Priority: --- Flags: gerald: maintainer-feedback+
gerald: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221111
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221050

Description Mason Loring Bliss freebsd_triage 2017-08-05 04:01:30 UTC
I can't get past this:

/usr/local/bin/gcc5  -I/usr/ports/multimedia/handbrake/work/HandBrake-1.0.7/build/contrib/include -std=gnu99 -O2 -pipe -DLIBICONV_PLUG -fstack-protector -Wl,-rpath=/usr/local/lib/gcc5 -isystem /usr/local/include -fno-strict-aliasing -DLIBICONV_PLUG -isystem /usr/local/include -DNDEBUG -O3 -Wall -Wdeclaration-after-statement -Wdisabled-optimization -Wpointer-arith -Wtype-limits -Wcast-qual -Wvla -Wimplicit-function-declaration -Wuninitialized -Wunused-variable -Wunused-but-set-variable -Wno-unused-function -I. -I"/usr/ports/multimedia/handbrake/work/HandBrake-1.0.7/build/contrib/libvpx/libvpx-1.5.0" -c -o vp8/common/generic/systemdependent.c.o vp8/common/generic/systemdependent.c
In file included from /usr/local/lib/gcc5/gcc/x86_64-portbld-freebsd11.0/5.4.0/include-fixed/unistd.h:46:0,
                 from vp8/common/generic/systemdependent.c:24:
/usr/local/lib/gcc5/gcc/x86_64-portbld-freebsd11.0/5.4.0/include-fixed/sys/types.h:266:9: error: unknown type name '__vm_ooffset_t'
 typedef __vm_ooffset_t vm_ooffset_t;
         ^
/usr/local/lib/gcc5/gcc/x86_64-portbld-freebsd11.0/5.4.0/include-fixed/sys/types.h:268:9: error: unknown type name '__vm_pindex_t'
 typedef __vm_pindex_t vm_pindex_t;
         ^
gmake[4]: *** [Makefile:154: vp8/common/generic/systemdependent.c.o] Error 1
gmake[3]: *** [Makefile:17: .DEFAULT] Error 2
gmake[3]: Leaving directory '/usr/ports/multimedia/handbrake/work/HandBrake-1.0.7/build/contrib/libvpx/libvpx-1.5.0'
gmake[2]: *** [../contrib/libvpx/module.rules:3: contrib/libvpx/.stamp.build] Error 2
gmake[2]: Leaving directory '/usr/ports/multimedia/handbrake/work/HandBrake-1.0.7/build'
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/multimedia/handbrake
*** Error code 1

Stop.
make: stopped in /usr/ports/multimedia/handbrake
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-05 14:02:23 UTC
This is a lang/gcc5 (and other gcc ports) issue, initially resolved in ports r444860 but not merged to the quarterly branch.

Assign to lang/gcc5 maintainer cc ports-secteam
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2017-08-06 04:38:40 UTC
A couple of comments:

 #1  This is not about lang/gcc5 not building.  There never was a problem
around lang/gcc5 not building (around this issue).

 #2  This only happens when you build lang/gcc5, then update src, then do
not rebuild lang/gcc5, but use it to build some other packages such as
multimedia/handbrake.

 #3  This will not happen using poudriere or any other way that provides
consistent builds.  (I do acknowledge there was an issue that we could
avoid via a change I made on trunk, at the slight risk of causing other
issues, but it triggered comparatively rarely, and see #2 and #3.)

So I do not think that merge-quarterly is a high priority, though I do
approve in case anyone wants to do so.


Mason, if you rebuild lang/gcc5 this problem should resolve itself.  Can 
you please confirm?
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2017-08-06 04:49:37 UTC
I failed to include the PR reference in the commit, but just pushed
the one line change back into the 2017Q3 branch.

Everything I wrote in the previous comment still applies.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-06 05:12:18 UTC
Committed (merged) in ports r447439
Comment 5 Mason Loring Bliss freebsd_triage 2017-08-06 15:17:17 UTC
I can confirm that this fixes the issue. Thank you.
Comment 6 Gerald Pfeifer freebsd_committer freebsd_triage 2017-08-06 15:43:20 UTC
Thank you for the confirmation, Mason!