Bug 221735

Summary: databases/sqlite3: could be nice to include sqlite3_analyzer
Product: Ports & Packages Reporter: Lapo Luchini <lapo>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: a.milevsky, amdmi3, pavelivolkov
Priority: --- Flags: bugzilla: maintainer-feedback? (pavelivolkov)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 220528    
Bug Blocks:    
Attachments:
Description Flags
proposed /usr/ports/databases/sqlite3_analyzer/Makefile
none
distinfo
none
pkg-descr
none
Patch none

Description Lapo Luchini 2017-08-23 09:04:07 UTC 
It could be nice to include `bin/sqlite3_analyzer` (available from the sqlite download page) in the port, or in a different port (I think it depends on TCL).

http://www.sqlite.org/sqlanalyze.html
http://www.sqlite.org/download.html
Comment 1 Pavel Volkov 2017-08-27 10:27:55 UTC 
Hello.
In the distribution that is used for this port, there are no corresponding files. But, do not despair. You can use the new port.

Look:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220528
or their source
https://github.com/pol73/sqlite-src

Thanks.
Comment 2 a.milevsky 2020-05-31 12:25:06 UTC 
Created attachment 215100 [details]
proposed /usr/ports/databases/sqlite3_analyzer/Makefile
Comment 3 a.milevsky 2020-05-31 12:25:32 UTC 
Created attachment 215101 [details]
distinfo
Comment 4 a.milevsky 2020-05-31 12:25:50 UTC 
Created attachment 215102 [details]
pkg-descr
Comment 5 a.milevsky 2020-05-31 12:26:51 UTC 
You can try to use linux binaries built via meta-port.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2021-02-16 15:06:34 UTC 
There's no need to use linux binaries for this.

sqlite3 provides complete source tarball, sqlite-src-3340100.zip (as opposed to currently used sqlite-autoconf-3340100.tar.gz), which contain analyzer and a bunch of other stuff (such as tests). sqlite3 should probably be switched to it.
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2021-02-16 15:10:37 UTC 
Created attachment 222490 [details]
Patch

A proposed patch to switch sqlite3 from sqlite-autoconf distfile to sqlite-src. Because of that, tcl is now required at buildtime, manpage needs to be installed manually, patch is no longer needed. Additionally, add TCL option which installs sqlite_analyzer and tcl extensions along the way. Also, switch to pkg-plist, PLIST_FILES this long is discouraged.
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-03-14 20:33:50 UTC 
A commit references this bug:

Author: amdmi3
Date: Sun Mar 14 20:33:04 UTC 2021
New revision: 568415
URL: https://svnweb.freebsd.org/changeset/ports/568415

Log:
  Add sqlite_analyzer support

  - Switch to more complete distfile which allows to enable
    TCL extensions and sqlite_analyzer
  - Switch to pkg-plist

  PR:		221735
  Reported by:	lapo@lapo.it
  Approved by:	maintainer timeout (pavelivolkov@gmail.com, 3.5 years)

Changes:
  head/databases/sqlite3/Makefile
  head/databases/sqlite3/distinfo
  head/databases/sqlite3/files/
  head/databases/sqlite3/pkg-plist