Bug 221896
| Summary: | [patch] adapt java/openjdk8 to new 'armv7' architecture | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Linimon <linimon> | ||||||
| Component: | Individual Port(s) | Assignee: | Mark Linimon <linimon> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | jkim | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | jkim:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221894 | ||||||||
| Attachments: |
|
||||||||
"${ARCH:C/armv*/arm/}" is wrong. It should be spelled "${ARCH:C/armv.*/arm/}", i.e., the pattern is a regular expression, not a glob pattern.
% cat armv7.mk
JDK_JVMDIR= lib/${ARCH:C/armv*/arm/:S/powerpc64/ppc64/}
% make -f armv7.mk -V JDK_JVMDIR ARCH=armv7
lib/arm7
Good catch. I'll have an updated patch shortly. Of course this seems to mean that :S and :M work differently. Ew. Created attachment 185893 [details]
corrected patch to java/openjdk8
(In reply to Mark Linimon from comment #4) It looks good to me. Ship it! A commit references this bug: Author: linimon Date: Fri Sep 1 14:42:43 UTC 2017 New revision: 449081 URL: https://svnweb.freebsd.org/changeset/ports/449081 Log: The src tree is splitting 32-bit arm support into 'armv6' and the new 'armv7'. This patch adds armv7 support. It should provide no regression on any existing architecture. PR: 221896 Approved by: maintainer Changes: head/java/openjdk8/Makefile Committed, thanks. |
Created attachment 185864 [details] patch to java/openjdk8 The src tree is splitting 32-bit arm support into 'armv6' and the new 'armv7'. This patch adds armv7 support. It should provide no regression on any existing architecture.