Bug 221971
| Summary: | ports-mgmt/portlint: allow USE_GITHUB before USES | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||
| Component: | Individual Port(s) | Assignee: | Joe Marcus Clarke <marcus> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | Flags: | bugzilla:
maintainer-feedback?
(marcus) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Committed to my repo pending the next release. A commit references this bug: Author: marcus Date: Sun Oct 8 17:58:52 UTC 2017 New revision: 451553 URL: https://svnweb.freebsd.org/changeset/ports/451553 Log: Update to 2.17.13. * Do not complain about USE_GITHUB before USES [1] * Make sure each variable in a dependency is fully expanded [2] * Clean up the earlier checks for BROKEN, etc. to prevent bogus warnings [3] * 'USE=execinfo' is removed with ports r450351. So stop suggesting to use it [4] PR: 221971 [1] 221605 [2] 222409 [3] 222653 [4] Submitted by: amdmi3 [1] jrm [2] Yasuhiro KIMURA <yasu@utahime.org> [4] Changes: head/ports-mgmt/portlint/Makefile head/ports-mgmt/portlint/src/portlint.pl Committed in 2.17.13. Thanks! This change is wrong, please revert it. Is this wrong in how it was coded, or should USE_GITHUB really be treated like other USE_* (even though it's more of a fetch thing)? This will be reverted in the next release pending the resolution of the debate. Reverted in 2.17.15. (In reply to Mathieu Arnold from comment #4) > This change is wrong, please revert it. Please explain why. Sure. There was debate on this from two committers, and I never saw an authoritative response from portmgr as to the right answer. If a decision is made to allow USE_GITHUB before USES, I'm down with making the change permanent. |
Created attachment 185968 [details] Patch While most USE_* vars are either additions or tweaks for USES, USE_GITHUB is different as it belongs to fetch, and not configure/build phase, therefore it's common to have USE_GITHUB/GH_* before USES knob. Allow this in portlint, and do not suggest something which would mix up natural "fetch-related stuff, then build-related stuff" order.