Created attachment 185968 [details]
While most USE_* vars are either additions or tweaks for USES, USE_GITHUB is different as it belongs to fetch, and not configure/build phase, therefore it's common to have USE_GITHUB/GH_* before USES knob. Allow this in portlint, and do not suggest something which would mix up natural "fetch-related stuff, then build-related stuff" order.
Committed to my repo pending the next release.
A commit references this bug:
Date: Sun Oct 8 17:58:52 UTC 2017
New revision: 451553
Update to 2.17.13.
* Do not complain about USE_GITHUB before USES 
* Make sure each variable in a dependency is fully expanded 
* Clean up the earlier checks for BROKEN, etc. to prevent bogus warnings 
* 'USE=execinfo' is removed with ports r450351. So stop suggesting to use it 
PR: 221971 
Submitted by: amdmi3 
Yasuhiro KIMURA <firstname.lastname@example.org> 
Committed in 2.17.13. Thanks!
This change is wrong, please revert it.
Is this wrong in how it was coded, or should USE_GITHUB really be treated like other USE_* (even though it's more of a fetch thing)?
This will be reverted in the next release pending the resolution of the debate.
Reverted in 2.17.15.
(In reply to Mathieu Arnold from comment #4)
> This change is wrong, please revert it.
Please explain why.
Sure. There was debate on this from two committers, and I never saw an authoritative response from portmgr as to the right answer. If a decision is made to allow USE_GITHUB before USES, I'm down with making the change permanent.