Bug 221982
| Summary: | bsdinstall creates wpa_supplicant.conf with missing indentation | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Ed Maste <emaste> |
| Component: | bin | Assignee: | Devin Teske <dteske> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | dteske |
| Priority: | --- | Flags: | emaste:
mfc-stable11?
|
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
| URL: | https://reviews.freebsd.org/D13190 | ||
Thanks for reporting this. I'll have a look ASAP A commit references this bug: Author: emaste Date: Wed Nov 22 15:18:11 UTC 2017 New revision: 326094 URL: https://svnweb.freebsd.org/changeset/base/326094 Log: Fix indentation in bsdinstall-created wpa_supplicant.conf r309934 cleaned up some cases in bsdinstall to use heredocs but broke the indentation of the generated output, because <<- heredocs strip leading tabs. PR: 221982 Reviewed by: allanjude, dteske MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D13190 Changes: head/usr.sbin/bsdinstall/scripts/wlanconfig A commit references this bug: Author: emaste Date: Thu Dec 7 03:57:12 UTC 2017 New revision: 326653 URL: https://svnweb.freebsd.org/changeset/base/326653 Log: MFC r326094: Fix indentation in bsdinstall-created wpa_supplicant.conf r311690 (MFC of r309934) cleaned up some cases in bsdinstall to use heredocs but broke the indentation of the generated output, because <<- heredocs strip leading tabs. PR: 221982 Changes: _U stable/11/ stable/11/usr.sbin/bsdinstall/scripts/wlanconfig batch change: For bugs that match the following - Status Is In progress AND - Untouched since 2018-01-01. AND - Affects Base System OR Documentation DO: Reset to open status. Note: I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed. MFC'd to 11, no more releases to come from 10. re-open, just observed this again on a fresh snapshot install A commit references this bug: Author: dteske Date: Wed May 20 21:39:20 UTC 2020 New revision: 361300 URL: https://svnweb.freebsd.org/changeset/base/361300 Log: Fix indentation in bsdinstall-created wpa_supplicant.conf PR: base/221982 Reported by: emaste Reviewed by: emaste, allanjude MFC after: 0 days X-MFC-to: stable/11 Differential Revision: https://reviews.freebsd.org/D23641 Changes: head/usr.sbin/bsdinstall/scripts/wlanconfig A commit references this bug: Author: dteske Date: Wed May 20 22:20:54 UTC 2020 New revision: 361305 URL: https://svnweb.freebsd.org/changeset/base/361305 Log: MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf PR: base/221982 Reported by: emaste Reviewed by: emaste, allanjude Differential Revision: https://reviews.freebsd.org/D23641 Changes: _U stable/11/ stable/11/usr.sbin/bsdinstall/scripts/wlanconfig A commit references this bug: Author: dteske Date: Wed May 20 23:27:02 UTC 2020 New revision: 361309 URL: https://svnweb.freebsd.org/changeset/base/361309 Log: MFC r361300: Fix indentation in bsdinstall-created wpa_supplicant.conf PR: base/221982 Reported by: emaste Reviewed by: emaste, allanjude Differential Revision: https://reviews.freebsd.org/D23641 Changes: _U stable/12/ stable/12/usr.sbin/bsdinstall/scripts/wlanconfig |
r309934 cleaned up some cases in bsdinstall to use heredocs but broke the indentation of the generated output - i.e. on a fresh install on a new laptop I ended up with: netowrk={ ssid="myssid" scan_ssid=0 psk="sharedkey" priority=5 } sh.1: If the operator is “<<-” instead of “<<”, then leading tabs in the here-doc-text are stripped.