Summary: | audio/abraca: unbreak build with vala 0.36 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Carlos J. Puga Medina <cpm> | ||||||
Component: | Individual Port(s) | Assignee: | Guido Falsi <madpilot> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | madpilot | ||||||
Priority: | --- | Flags: | madpilot:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 221941 | ||||||||
Attachments: |
|
Description
Carlos J. Puga Medina
2017-09-03 23:04:47 UTC
Created attachment 186044 [details]
patch
- Add LICENSE and LICENSE_FILE
- Fix build with vala 0.36
- Update WWW in pkg-descr
- Bump PORTREVISION
Hi, Thanks for the patch. I'll test it and commit it soon. Hi, After a quick test I discovered that this patch makes abraca fail with the vala version present in the tree now. This means I cannot commit this patch right away. Are you planning on committing this patch together with the vala update? In such a case I have no objection. Created attachment 186075 [details]
patch
Update patch to make it compatible with current vala 0.30 version.
(In reply to Guido Falsi from comment #3) Please, would you mind checking if it works as expected? It should work with both versions. Thanks for this further patch. It works better. Going to commit it a bit later. (In reply to Guido Falsi from comment #6) Thanks, Guido! I'm not sure if all of the if-else-endif statement are really necessary, but it's worth checking. As an example, see the attached patch from bug 222026 https://bz-attachments.freebsd.org/attachment.cgi?id=186086 Fix committed, after suggested minor changes. Thanks! A commit references this bug: Author: madpilot Date: Thu Sep 7 13:23:26 UTC 2017 New revision: 449397 URL: https://svnweb.freebsd.org/changeset/ports/449397 Log: - Fix build with vala 0.36 - Add LICENSE and LICENSE_FILE - Update WWW in pkg-descr PR: 222037 Submitted by: cpm@ Changes: head/audio/abraca/Makefile head/audio/abraca/files/ head/audio/abraca/files/patch-src_abraca-filter-searchbox.vala head/audio/abraca/files/patch-src_abraca-medialib.vala head/audio/abraca/files/patch-src_abraca-playlist-model.vala head/audio/abraca/files/patch-src_abraca-resolver.vala head/audio/abraca/files/patch-src_abraca-server-browser-dialog.vala head/audio/abraca/pkg-descr |