Bug 222277

Summary: Don't (try to) build qlnx if the user objects to binary blobs
Product: Base System Reporter: Fabian Keil <fk>
Component: kernAssignee: Ed Maste <emaste>
Status: Closed FIXED    
Severity: Affects Many People CC: emaste
Priority: --- Keywords: regression
Version: CURRENTFlags: emaste: mfc-stable11+
emaste: mfc-stable10-
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Don't (try to) build qlnx if the user objects to binary blobs none

Description Fabian Keil 2017-09-13 05:52:34 UTC 
Created attachment 186319 [details]
Don't (try to) build qlnx if the user objects to binary blobs

As previously reported in:
https://lists.freebsd.org/pipermail/svn-src-all/2017-April/143083.html
the qlnx module contains source-less microcode but is built and
installed even if WITHOUT_SOURCELESS_UCODE is set.

The attached patch fixes this.

Obtained from: ElectroBSD
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-09-13 12:17:07 UTC 
A commit references this bug:

Author: emaste
Date: Wed Sep 13 12:16:27 UTC 2017
New revision: 323539
URL: https://svnweb.freebsd.org/changeset/base/323539

Log:
  qlnx: exclude if WITHOUT_SOURCELESS_UCODE set

  PR:		222277
  Submitted by:	Fabian Keil
  Obtained from:	ElectroBSD
  MFC after:	1 week

Changes:
  head/sys/modules/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-09-20 22:11:30 UTC 
A commit references this bug:

Author: emaste
Date: Wed Sep 20 22:11:01 UTC 2017
New revision: 323837
URL: https://svnweb.freebsd.org/changeset/base/323837

Log:
  MFC r323539: qlnx: exclude if WITHOUT_SOURCELESS_UCODE set

  PR:		222277
  Submitted by:	Fabian Keil
  Obtained from:	ElectroBSD

Changes:
_U  stable/11/
  stable/11/sys/modules/Makefile
Comment 3 Ed Maste freebsd_committer freebsd_triage 2017-10-13 17:56:12 UTC 
Encountered a conflict merging to stable/10 and no further releases are planned, so this will go to HEAD and stable/11 only.

Thank you for the submission.