Bug 222392

Summary: graphics/appleseed: Fails to compile with C++11
Product: Ports & Packages Reporter: Roger Leigh <rleigh>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (danfe)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/appleseedhq/appleseed/pull/1615
Bug Depends on:    
Bug Blocks: 221890    
Attachments:
Description Flags
Correct spinlock init for C++11 none

Description Roger Leigh 2017-09-17 12:21:57 UTC 
Created attachment 186458 [details]
Correct spinlock init for C++11

See upstream pull request: https://github.com/appleseedhq/appleseed/pull/1615

Also see attached patch for the ports tree.  Tested with poudriere on FreeBSD 10.3 and 11.1.
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-11-13 11:42:33 UTC 
Thanks; I'll incorporate the patch together with upcoming update to version 1.6.0 (not the latest, but that's not possible at this moment due to missing RTTI support in LLVM/OSL).
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-11-13 15:36:32 UTC 
A commit references this bug:

Author: danfe
Date: Mon Nov 13 15:36:11 UTC 2017
New revision: 454120
URL: https://svnweb.freebsd.org/changeset/ports/454120

Log:
  - Belatedly update `graphics/appleseed' to version 1.6.0, the latest
    version where OSL support is optional (further updates require RTTI
    enabled in both LLVM and OSL, and thus currently not possible)
  - Allow to build in C++11 mode and backport a patch to fix spinlock
    initialization to match the way it is initialized internally by
    Boost: copy and assignment operators are deleted, which this logic
    was attempting to use (in fact, it's surprising that it was working
    before because it was most likely not possible even with C++98,
    unless this is a very recent change in Boost) [*]
  - While here, adjust OSL_BROKEN message to give the specific reason

  PR:		222392 [*]
  Submitted by:	Roger Leigh

Changes:
  head/graphics/appleseed/Makefile
  head/graphics/appleseed/distinfo
  head/graphics/appleseed/files/patch-CMakeLists.txt
  head/graphics/appleseed/files/patch-src_appleseed_foundation_platform_thread.h
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-11-13 15:41:19 UTC 
Patch had been committed as part of ports r454120, thanks!