Bug 222392 - graphics/appleseed: Fails to compile with C++11
Summary: graphics/appleseed: Fails to compile with C++11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL: https://github.com/appleseedhq/apples...
Keywords:
Depends on:
Blocks: 221890
  Show dependency tree / graph
 
Reported: 2017-09-17 12:21 UTC by Roger Leigh
Modified: 2017-11-13 15:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
Correct spinlock init for C++11 (1.34 KB, patch)
2017-09-17 12:21 UTC, Roger Leigh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Leigh 2017-09-17 12:21:57 UTC 
Created attachment 186458 [details]
Correct spinlock init for C++11

See upstream pull request: https://github.com/appleseedhq/appleseed/pull/1615

Also see attached patch for the ports tree.  Tested with poudriere on FreeBSD 10.3 and 11.1.
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-11-13 11:42:33 UTC 
Thanks; I'll incorporate the patch together with upcoming update to version 1.6.0 (not the latest, but that's not possible at this moment due to missing RTTI support in LLVM/OSL).
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-11-13 15:36:32 UTC 
A commit references this bug:

Author: danfe
Date: Mon Nov 13 15:36:11 UTC 2017
New revision: 454120
URL: https://svnweb.freebsd.org/changeset/ports/454120

Log:
  - Belatedly update `graphics/appleseed' to version 1.6.0, the latest
    version where OSL support is optional (further updates require RTTI
    enabled in both LLVM and OSL, and thus currently not possible)
  - Allow to build in C++11 mode and backport a patch to fix spinlock
    initialization to match the way it is initialized internally by
    Boost: copy and assignment operators are deleted, which this logic
    was attempting to use (in fact, it's surprising that it was working
    before because it was most likely not possible even with C++98,
    unless this is a very recent change in Boost) [*]
  - While here, adjust OSL_BROKEN message to give the specific reason

  PR:		222392 [*]
  Submitted by:	Roger Leigh

Changes:
  head/graphics/appleseed/Makefile
  head/graphics/appleseed/distinfo
  head/graphics/appleseed/files/patch-CMakeLists.txt
  head/graphics/appleseed/files/patch-src_appleseed_foundation_platform_thread.h
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-11-13 15:41:19 UTC 
Patch had been committed as part of ports r454120, thanks!