Bug 222424

Summary: devel/liblas12: Fix build error on HEAD
Product: Ports & Packages Reporter: Rainer Hurling <rhurlin>
Component: Individual Port(s)Assignee: Luca Pizzamiglio <pizzamig>
Status: Closed FIXED    
Severity: Affects Only Me CC: pizzamig, rhurlin
Priority: --- Flags: rhurlin: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch for devel/liblas12 to circumstance guid error rhurlin: maintainer-approval+

Description Rainer Hurling freebsd_committer freebsd_triage 2017-09-18 11:02:40 UTC
Created attachment 186507 [details]
patch for devel/liblas12 to circumstance guid error

For some weeks now devel/liblas12 does not build on HEAD because of this error:

las_c_api.cpp:748:28: error: qualified reference to 'guid' is a constructor name rather than a type in this context
        id = liblas::guid::guid(value);
                           ^
las_c_api.cpp:1545:28: error: qualified reference to 'guid' is a constructor name rather than a type in this context
        id = liblas::guid::guid(string);
                           ^

The patch should solve this behavior on HEAD, hopefully without regressions on 10.x and 11.x


Tested with Poudriere (10.3i/a, 11.0i/a  and, HEADi/a, no options available.

portlint -AC seems happy.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-11-03 15:28:20 UTC
A commit references this bug:

Author: pizzamig
Date: Fri Nov  3 15:27:25 UTC 2017
New revision: 453408
URL: https://svnweb.freebsd.org/changeset/ports/453408

Log:
  devel/liblas12: Fix build error on CURRENT

  PR:		222424
  Submitted by:	rhurlin@gwdg.de (maintainer)
  Approved by:	olivier (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12786

Changes:
  head/devel/liblas12/files/
  head/devel/liblas12/files/patch-src_las__c__api.cpp
Comment 2 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-03 15:29:24 UTC
Thanks!