Bug 222424 - devel/liblas12: Fix build error on HEAD
Summary: devel/liblas12: Fix build error on HEAD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-18 11:02 UTC by Rainer Hurling
Modified: 2017-11-03 15:29 UTC (History)
2 users (show)

See Also:
rhurlin: maintainer-feedback+

Attachments
patch for devel/liblas12 to circumstance guid error (1.29 KB, patch)
2017-09-18 11:02 UTC, Rainer Hurling 		rhurlin: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2017-09-18 11:02:40 UTC 
Created attachment 186507 [details]
patch for devel/liblas12 to circumstance guid error

For some weeks now devel/liblas12 does not build on HEAD because of this error:

las_c_api.cpp:748:28: error: qualified reference to 'guid' is a constructor name rather than a type in this context
        id = liblas::guid::guid(value);
                           ^
las_c_api.cpp:1545:28: error: qualified reference to 'guid' is a constructor name rather than a type in this context
        id = liblas::guid::guid(string);
                           ^

The patch should solve this behavior on HEAD, hopefully without regressions on 10.x and 11.x


Tested with Poudriere (10.3i/a, 11.0i/a  and, HEADi/a, no options available.

portlint -AC seems happy.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-11-03 15:28:20 UTC 
A commit references this bug:

Author: pizzamig
Date: Fri Nov  3 15:27:25 UTC 2017
New revision: 453408
URL: https://svnweb.freebsd.org/changeset/ports/453408

Log:
  devel/liblas12: Fix build error on CURRENT

  PR:		222424
  Submitted by:	rhurlin@gwdg.de (maintainer)
  Approved by:	olivier (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12786

Changes:
  head/devel/liblas12/files/
  head/devel/liblas12/files/patch-src_las__c__api.cpp
Comment 2 Luca Pizzamiglio freebsd_committer freebsd_triage 2017-11-03 15:29:24 UTC 
Thanks!