Bug 223063
| Summary: | devel/php-composer: Update to 1.5.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Felix Flor <freebsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Jochen Neumeister <joneum> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | cyberbotx, joneum, tz | ||||||
| Priority: | --- | Flags: | cyberbotx:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Felix Flor
2017-10-17 13:14:15 UTC
Please submit an actual patch for an attachment, not the full Makefile. I'm pretty sure that a committer would not want to deal with the above. Otherwise, this looks fine. Hi eqvvs :-) what is the reason to add "mbstring"? Is there a reason for this? Is there a link for a changelog? There are changelogs on their GitHub: https://github.com/composer/composer/releases/tag/1.4.3 https://github.com/composer/composer/releases/tag/1.5.0 https://github.com/composer/composer/releases/tag/1.5.1 https://github.com/composer/composer/releases/tag/1.5.2 @Naram Qashat: Aloha Naram, i'm sorry, its my first patch for feebsd i ever done. i will upload a secound attachment like the description. @Jochen Neumeister: Aloha Jochen, i installed the php-composer from ports with pkg and with make. in both cases, if i try to use composer, i get an fatal error that tells me the mbstring is missing. after i installed mbsting i worked fine. So i thought it make sense ;) In the changelog on composer nothing is written about mbsting. Created attachment 187263 [details]
Update to 1.5.2
*** Bug 223062 has been marked as a duplicate of this bug. *** @eqvvs Please obsolete the wrong Patch / Makefile to avoid confusions. @Jochen The Patch is approved by me. No need for a Diff Review. I entrust the correct commit message to you ;) @Torsten Zuehlsdorff done (In reply to Torsten Zuehlsdorff from comment #7) Ups, i read this too late. There is now a open review, sorry. A commit references this bug: Author: joneum Date: Wed Oct 18 08:39:34 UTC 2017 New revision: 452320 URL: https://svnweb.freebsd.org/changeset/ports/452320 Log: devel/php-composer: Update from 1.4.2 to 1.5.2 -Changelog: https://github.com/composer/composer/releases/tag/1.4.3 https://github.com/composer/composer/releases/tag/1.5.0 https://github.com/composer/composer/releases/tag/1.5.1 https://github.com/composer/composer/releases/tag/1.5.2 Add missing mbstring module to avoid fatal PHP error PR: 223063 Reported by: eqvvs <freebsd@flornet.de> Approved by: Naram Qashat <cyverbotx@cyberbotx.com> (maintainer), tz (mentor) MFH: 2017Q4 Differential Revision: https://reviews.freebsd.org/D12711 Changes: head/devel/php-composer/Makefile head/devel/php-composer/distinfo Committed, thanks :-) Now i am waiting for the MFH 2017Q4 approval A commit references this bug: Author: joneum Date: Wed Oct 25 10:12:26 UTC 2017 New revision: 452839 URL: https://svnweb.freebsd.org/changeset/ports/452839 Log: MFH: r452320 devel/php-composer: Update from 1.4.2 to 1.5.2 -Changelog: https://github.com/composer/composer/releases/tag/1.4.3 https://github.com/composer/composer/releases/tag/1.5.0 https://github.com/composer/composer/releases/tag/1.5.1 https://github.com/composer/composer/releases/tag/1.5.2 Add missing mbstring module to avoid fatal PHP error PR: 223063 Reported by: eqvvs <freebsd@flornet.de> Approved by: Naram Qashat <cyverbotx@cyberbotx.com> (maintainer), tz (mentor) Differential Revision: https://reviews.freebsd.org/D12711 Approved by: ports-secteam (swills) Changes: _U branches/2017Q4/ branches/2017Q4/devel/php-composer/Makefile branches/2017Q4/devel/php-composer/distinfo |
