Bug 224034

Summary: www/palemoon: sndio: improve and clamp float->s16 conversion
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: lichray
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
palemoon.diff lichray: maintainer-approval+

Description Tobias Kortkamp freebsd_committer 2017-12-02 10:25:38 UTC
Created attachment 188468 [details]
palemoon.diff

Hi,

when Pale Moon (compiled with SNDIO=on) tries to playback files with
float samples then something is very wrong and we can hear some
annoying sound crackling / distortion.  For example this can be heard
when playing this video [1].

To fix it we need to backport one more patch for the sndio backend
that improves the float->s16 conversion function.

Thanks!

[1] https://www.youtube.com/watch?v=iJxM-YNc4oE
Comment 1 lichray 2017-12-03 04:46:19 UTC
Comment on attachment 188468 [details]
palemoon.diff

Tested.
Comment 2 commit-hook freebsd_committer 2017-12-03 07:17:29 UTC
A commit references this bug:

Author: tobik
Date: Sun Dec  3 07:17:18 UTC 2017
New revision: 455391
URL: https://svnweb.freebsd.org/changeset/ports/455391

Log:
  www/palemoon: sndio: improve and clamp float->s16 conversion

  This fixes sound glitches/crackling when playing audio or video clips
  with float samples with SNDIO=on.

  PR:		224034
  Submitted by:	lichray@gmail.com (maintainer)
  Obtained from:	cubeb

Changes:
  head/www/palemoon/Makefile
  head/www/palemoon/files/patch-cubeb5ffce9e91b
Comment 3 Tobias Kortkamp freebsd_committer 2017-12-03 07:19:31 UTC
Committed. Thanks!