Bug 224081

Summary: net/wireshark: move spandsp dependency under RTP option
Product: Ports & Packages Reporter: Sergey Akhmatov <sergey>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (marcus)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
spandsp dependency patch none

Description Sergey Akhmatov 2017-12-04 13:36:27 UTC
Created attachment 188521 [details]
spandsp dependency patch

We should move dependency on libspandsp.so under RTP option.

Update to 2.4.2 in r454915 added libspandsp.so:comms/spandsp to LIB_DEPENDS unconditionally
This lib is only used by RTP-player which is:
a) Optional
b) Depends on GUI

wireshark build without RTP or without GUI (net/tshark) still depends on comms/spandsp, but actually isn't even linked with this .so, pulling unnecessary packages to GUI-less system, such as:
comms/spandsp
graphics/tiff
graphics/jpeg-turbo
graphics/jbigkit
Comment 1 Joe Marcus Clarke freebsd_committer 2017-12-28 23:55:35 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2017-12-28 23:55:52 UTC
A commit references this bug:

Author: marcus
Date: Thu Dec 28 23:55:15 UTC 2017
New revision: 457487
URL: https://svnweb.freebsd.org/changeset/ports/457487

Log:
  Move the libspandsp dependency to RTP.

  This cleans up the GUI-less dependency list when RTP is not desired.

  PR:		224081
  Submitted by:	sergey@akhmatov.ru

Changes:
  head/net/wireshark/Makefile