Bug 224081 - net/wireshark: move spandsp dependency under RTP option
Summary: net/wireshark: move spandsp dependency under RTP option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-04 13:36 UTC by Sergey Akhmatov
Modified: 2017-12-28 23:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
spandsp dependency patch (1.10 KB, text/plain)
2017-12-04 13:36 UTC, Sergey Akhmatov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akhmatov 2017-12-04 13:36:27 UTC
Created attachment 188521 [details]
spandsp dependency patch

We should move dependency on libspandsp.so under RTP option.

Update to 2.4.2 in r454915 added libspandsp.so:comms/spandsp to LIB_DEPENDS unconditionally
This lib is only used by RTP-player which is:
a) Optional
b) Depends on GUI

wireshark build without RTP or without GUI (net/tshark) still depends on comms/spandsp, but actually isn't even linked with this .so, pulling unnecessary packages to GUI-less system, such as:
comms/spandsp
graphics/tiff
graphics/jpeg-turbo
graphics/jbigkit
Comment 1 Joe Marcus Clarke freebsd_committer 2017-12-28 23:55:35 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2017-12-28 23:55:52 UTC
A commit references this bug:

Author: marcus
Date: Thu Dec 28 23:55:15 UTC 2017
New revision: 457487
URL: https://svnweb.freebsd.org/changeset/ports/457487

Log:
  Move the libspandsp dependency to RTP.

  This cleans up the GUI-less dependency list when RTP is not desired.

  PR:		224081
  Submitted by:	sergey@akhmatov.ru

Changes:
  head/net/wireshark/Makefile