Bug 224202
| Summary: | [PATCH] x11-toolkits/wlc: Update to 0.0.10 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Johannes Lundberg <johalun0> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-x11 (Nobody) <x11> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Only Me | CC: | val, zeising | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(x11) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | 227423 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Working on this. I get a build failure when test building this in poudriere, both on amd64 and i386. The last bit of the error message is: -- The following REQUIRED packages have not been found: * Wayland, Protocol for implementing compositors, <http://wayland.freedesktop.org/> CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: WAYLAND_EGL_LIBRARIES (ADVANCED) linked by target "wlc-tests" in directory /wrkdirs/usr/ports/x11-toolkits/wlc/work/wlc-0.0.10/src linked by target "wlc" in directory /wrkdirs/usr/ports/x11-toolkits/wlc/work/wlc-0.0.10/src -- Configuring incomplete, errors occurred! See also "/wrkdirs/usr/ports/x11-toolkits/wlc/work/wlc-0.0.10/CMakeFiles/CMakeOutput.log". *** Error code 1 Stop. make: stopped in /usr/ports/x11-toolkits/wlc I'll attach a complete log in a moment, but it seems like there are some dependency missing (or cmake at least fails to find it). Created attachment 188670 [details]
Log of failed build
Build log of failed build.
It needs mesa-libs built with wayland=on. If we won't make it default, we need flavors for it. That explains. I'll put this on hold for a little while then, until I can test with wayland on in mesa stuff. I think flavours or sub-packages for mesa-libs is a while off, although this sounds like a candidate for it. (In reply to Johannes Lundberg from comment #4) Maybe add libwayland-egl.so:graphics/mesa-libs to LIB_DEPENDS to detect this earlier? IIRC we've had separate libGL libEGL … packages before, that was awful. If ports had a sub-packages feature that actually created multiple packages from one port build, that would be great. Like Arch Linux: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mesa — one build (mesa), many packages (Vulkan, OpenCL, VAAPI, VDPAU, the rest) But for now, "build all the things" is the better option. And it's actually what's happening mostly — GLESv2 is always built, EGL is ~always built (when LLVM is available). Only the tiny 4.5kb libwayland-egl.so is optional. (Okay, it depends on the wayland package, so adds a bit more than 4.5kb, but whatever) > Maybe add libwayland-egl.so:graphics/mesa-libs to LIB_DEPENDS to detect this earlier?
Yes, I agree. Will add this.
I also agree we should set wayland=on as default on all related ports. It adds so little in package sizes but enables so much... Not to mention, Wayland-based compositors will be the default window servers instead of X11 soon enough so there's no reason not to. It's just a matter of time.
While libwayland-egl no longer being tied by WAYLAND option in mesa-libs allows the update to proceed this port is no longer useful. https://github.com/Cloudef/wlc/commit/6e2c49bf5789115bf33873f3e0ebe603c8e7725d https://github.com/swaywm/sway/commit/6edc32848f67fe3ea370e12b64019cef6c137840 https://github.com/swaywm/sway/commit/c301b14a42c007bf3b69fef6053fa2466e201309 |
Created attachment 188648 [details] Patch to update x11-toolkits/wlc to 0.0.10 Update to 0.0.10. FreeBSD patches has been upstreamed so no need patch files in ports anymore.