Bug 224383

Summary: www/chromium: fails to build on aarch64
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Carlos J. Puga Medina <cpm>
Status: Closed FIXED    
Severity: Affects Only Me CC: cpm, freebsd-arm, linimon, mikael
Priority: --- Flags: bugzilla: maintainer-feedback? (chromium)
Version: Latest   
Hardware: arm64   
OS: Any   
Bug Depends on: 220291    
Bug Blocks:    

Description Jan Beich freebsd_committer freebsd_triage 2017-12-16 15:40:24 UTC
../../third_party/skia/src/core/SkCpu.cpp:84:27: error: use of undeclared identifier 'getauxval'
        uint32_t hwcaps = getauxval(AT_HWCAP);
                          ^

../../components/safe_browsing_db/v4_rice.cc:120:18: error: use of overloaded operator '&' is ambiguous (with operand types 'StrictNumeric<unsigned int>' and 'unsigned int')
  out->push_back(htonl(last_value.ValueOrDie()));
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p454917_s326235/logs/errors/chromium-61.0.3163.100_3.log
http://thunderx1.nyi.freebsd.org/data/111arm64-default/455387/logs/errors/chromium-61.0.3163.100_3.log
http://thunderx1.nyi.freebsd.org/data/111arm64-quarterly/456211/logs/chromium-61.0.3163.100_1.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2017-12-16 15:43:12 UTC
getauxval() issue is known. Maybe wait until base system is fixed.

https://lists.freebsd.org/pipermail/freebsd-ports/2017-December/111483.html
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-12-16 15:46:23 UTC
According to bug 223016 comment 4 AT_HWCAP may remain a nop on aarch64, so you'd need to write *new* code to detect CRC32.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-04-18 07:21:53 UTC
A commit references this bug:

Author: cpm
Date: Wed Apr 18 07:21:06 UTC 2018
New revision: 467685
URL: https://svnweb.freebsd.org/changeset/ports/467685

Log:
  www/chromium: Unbreak build on 12/aarch64

  ../../third_party/skia/src/core/SkCpu.cpp:84:27: error: use of undeclared identifier 'getauxval'
          uint32_t hwcaps = getauxval(AT_HWCAP);
                            ^

  PR:		224383
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com>
  Reported by:	jbeich

Changes:
  head/www/chromium/Makefile
  head/www/chromium/files/patch-third__party_skia_src_core_SkCpu.cpp
  head/www/chromium/files/patch-third_party_crc32c_src_src_crc32c__arm64__linux__check.h
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2018-06-11 04:12:27 UTC
Apparently committed as r467685.