Bug 225226
| Summary: | print/qpdf: Update to 7.1.0 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitri Goutnik <dmgk> | ||||||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | admin, cpm, d.y.kazarov, jhibbits, joneum, ohartmann, vvd, yuri | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | Flags: | yuri:
maintainer-feedback+
|
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | http://qpdf.sourceforge.net/files/qpdf-manual.html#ref.release-notes | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dmitri Goutnik
2018-01-16 16:43:31 UTC
Patch to Makefile is rejected. Could you please update it? Thanks! Created attachment 190157 [details] patch file Updated for ports r460298 *** Bug 222056 has been marked as a duplicate of this bug. *** Maintainer timeout expired. Committed. Thank you for the patch! A commit references this bug: Author: yuri Date: Wed Jan 31 04:39:24 UTC 2018 New revision: 460458 URL: https://svnweb.freebsd.org/changeset/ports/460458 Log: print/qpdf: Update to 7.1.0 Additional changes: * Added a patch to work around the missing include: https://github.com/qpdf/qpdf/pull/172 * Added a patch to fix the clang and gcc build problem: https://github.com/qpdf/qpdf/issues/177 PR: 225226 Reported by: Dmitri Goutnik <dg@syrec.org> Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D14119 Changes: head/print/qpdf/Makefile head/print/qpdf/distinfo head/print/qpdf/files/patch-libqpdf_Pl__PNGFilter.cc head/print/qpdf/files/patch-libqpdf_QUtil.cc head/print/qpdf/files/patch-libtests-build.mk head/print/qpdf/files/patch-make-libtool.mk head/print/qpdf/files/patch-make_libtool.mk head/print/qpdf/pkg-plist Port can't be build if installed previous version. Look at this: -L/usr/local/lib -lqpdf -Llibqpdf/build Must be: -lqpdf -Llibqpdf/build -L/usr/local/lib Local libs MUST have higher priority. Why nobody didn't test port before commit on _real_ system?! libtool: link: c++ -O2 -pipe -march=prescott -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wold-style-cast -Wall libtests/build/buffer.o -o libtests/build/buffer -fstack-protector -ljpeg -lz -L/usr/local/lib -lqpdf -Llibqpdf/build libtests/build/bits.o: In function `main': libtests/bits.cc:(.text+0x62b): undefined reference to `BitStream::getBitsSigned(int)' libtests/bits.cc:(.text+0x6a7): undefined reference to `BitStream::getBitsSigned(int)' libtests/bits.cc:(.text+0x723): undefined reference to `BitStream::getBitsSigned(int)' libtests/bits.cc:(.text+0x79f): undefined reference to `BitStream::getBitsSigned(int)' libtests/bits.cc:(.text+0x81b): undefined reference to `BitStream::getBitsSigned(int)' libtests/bits.cc:(.text+0xab4): undefined reference to `BitWriter::writeBitsSigned(long long, unsigned int)' libtests/bits.cc:(.text+0xac3): undefined reference to `BitWriter::writeBitsSigned(long long, unsigned int)' libtests/bits.cc:(.text+0xad2): undefined reference to `BitWriter::writeBitsSigned(long long, unsigned int)' libtests/bits.cc:(.text+0xae1): undefined reference to `BitWriter::writeBitsSigned(long long, unsigned int)' libtests/bits.cc:(.text+0xaf0): undefined reference to `BitWriter::writeBitsSigned(long long, unsigned int)' c++: error: linker command failed with exit code 1 (use -v to see invocation) gmake[2]: *** [libtests/build.mk:44: libtests/build/bits] Error 1 gmake[2]: *** Waiting for unfinished jobs.... libtool: link: c++ -O2 -pipe -march=prescott -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wold-style-cast -Wall libtests/build/concatenate.o -o libtests/build/concatenate -fstack-protector -ljpeg -lz -L/usr/local/lib -lqpdf -Llibqpdf/build gmake[2]: Leaving directory '/usr/obj/usr/ports/print/qpdf/work/qpdf-7.1.0' ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 Stop. make[1]: stopped in /usr/ports/print/qpdf *** Error code 1 Stop. make: stopped in /usr/ports/print/qpdf Created attachment 190221 [details]
fix build with prev version installed
Re-opened. Thank you for your patch. *** Bug 225606 has been marked as a duplicate of this bug. *** See Bug 225608 . Update to 7.1.0 results in linker error on CURRENT and so ports requiring print/qpdf depending on options, like print/hplip, fails to build/install. *** Bug 225608 has been marked as a duplicate of this bug. *** The upstream is expected to accept this in the release: https://github.com/qpdf/qpdf/issues/176 Committed the 7.1.1 update that fixed these problems: * build breaks when previous version is installed: https://github.com/qpdf/qpdf/issues/176 * error: reinterpret_cast from 'nullptr_t' to 'char *': https://github.com/qpdf/qpdf/issues/177 A commit references this bug: Author: yuri Date: Mon Feb 5 03:24:42 UTC 2018 New revision: 460959 URL: https://svnweb.freebsd.org/changeset/ports/460959 Log: print/qpdf: Update to 7.1.1 (a followup release) Fixed bugs that were left by the first commit for bug#225226 that updated qpdf to 7.1.0: * build breaks when previous version is installed: https://github.com/qpdf/qpdf/issues/176 * error: reinterpret_cast from 'nullptr_t' to 'char *': https://github.com/qpdf/qpdf/issues/177 PR: 225226 Reported by: several users Approved by: adamw (mentor) Differential Revision: https://reviews.freebsd.org/D14201 Changes: head/print/qpdf/Makefile head/print/qpdf/distinfo head/print/qpdf/files/patch-libqpdf_Pl__PNGFilter.cc head/print/qpdf/files/patch-libqpdf_QUtil.cc head/print/qpdf/pkg-plist Thanks! |