Bug 225282

Summary: textproc/tinyxml2: plist failures after update to 6.0.0
Product: Ports & Packages Reporter: Phillip R. Jaenke <prj>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: prj
Priority: --- Flags: sunpoet: maintainer-feedback-
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
tinyxml2_plist.patch none

Description Phillip R. Jaenke 2018-01-17 20:52:04 UTC 
Created attachment 189864 [details]
tinyxml2_plist.patch

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libtinyxml2d.a
Error: Orphaned: lib/libtinyxml2d.so
Error: Orphaned: lib/libtinyxml2d.so.6
Error: Orphaned: lib/libtinyxml2d.so.%%PORTVERSION%%
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/libtinyxml2.a
Error: Missing: lib/libtinyxml2.so
Error: Missing: lib/libtinyxml2.so.6
Error: Missing: lib/libtinyxml2.so.%%PORTVERSION%%
===> Error: Plist issues found.
*** Error code 1

Note the output changed to 'libtinyxml2d' - ABI tracker reports this occurred in the 4.0->5.0 transition. 
https://abi-laboratory.pro/tracker/objects_report/tinyxml2/4.0.1/5.0.0/report.html

Patch to resolve is attached.
Comment 1 Phillip R. Jaenke 2018-01-17 21:01:37 UTC 
This change has also broken multimedia/libmediainfo, and probably breaks some other things that I haven't found yet.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-18 13:19:35 UTC 
You cannot fully rely on ABI tracker results.
The "d" suffix indicates you're building a debug version which is not the default configuration.
Comment 3 Phillip R. Jaenke 2018-01-18 19:19:17 UTC 
Ah crap, you're right, I missed removing one of my DEBUG flags here. Still, that's a problem. Just of a different sort.

If I build tinyxml2 WITH_DEBUG=1 that should not be breaking the port or things that depend on the port. But, that's exactly what happens right now. I'm a lot less sure how to fix that though.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-18 19:58:17 UTC 
I could add a DEBUG option to handle the PLIST issue. Try this patch and enable DEBUG option. But I haven't tested if libmediainfo recognizes tinyxml2 with "d" suffix.

https://people.FreeBSD.org/~sunpoet/patch/textproc-tinyxml2.txt
Comment 5 Phillip R. Jaenke 2018-01-18 20:04:51 UTC 
That seems eminently reasonable to me; didn't know that was possible to do with plist.

libmediainfo definitely does not know how to handle the d suffix when debug is enabled, and causes a lib-depends fail. I'm not sure how to handle that one gracefully. Is there even a standard way to specify different LIB_DEPENDS based on DEBUG versus not? This seems like a problem that may have to be acceptable breakage during DEBUG.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-01-20 08:32:20 UTC 
Hmm, it looks like the simplest solution is to remove the "d" suffix.

libmediainfo does not recognize libtinyxml2d even if we modify the LIB_DEPENDS line in Makefile.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-01-21 09:00:53 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Jan 21 09:00:19 UTC 2018
New revision: 459575
URL: https://svnweb.freebsd.org/changeset/ports/459575

Log:
  Fix packaging with WITH_DEBUG defined

  PR:		225282
  Reported by:	Phillip R. Jaenke <prj@rootwyrm.com>

Changes:
  head/textproc/tinyxml2/Makefile