Bug 225316

Summary: net-mgmt/collectd5: Fix varnish plugin build
Product: Ports & Packages Reporter: Luca Pizzamiglio <pizzamig>
Component: Individual Port(s)Assignee: Luca Pizzamiglio <pizzamig>
Status: Closed FIXED    
Severity: Affects Only Me CC: ports
Priority: --- Keywords: easy, patch
Version: LatestFlags: linimon: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
The fixing patch none

Description Luca Pizzamiglio freebsd_committer 2018-01-19 14:20:42 UTC
Created attachment 189905 [details]
The fixing patch

Enabling the varnish plugin support, collectd5 fails to build during the configure phase, because the configure script is not able to find varnish headers.

The proposed patch remove the usage of --with-libvarnish=/usr/local that automatically set also CFLAGS=-I/usr/local/include (it should be /usr/local/include/varnish)

In this way, the configure script will use pkgconf that provides the correct value for LDFLAGS and CFLAGS.
Comment 1 Krzysztof 2018-01-19 20:20:14 UTC
Yes, I approve this patch.
Comment 2 commit-hook freebsd_committer 2018-01-22 09:44:56 UTC
A commit references this bug:

Author: pizzamig
Date: Mon Jan 22 09:44:43 UTC 2018
New revision: 459641
URL: https://svnweb.freebsd.org/changeset/ports/459641

Log:
  net-mgmt/collectd5: Fix varnish plugin build

  PR:		225316
  Approved by:	maintainer
  Sponsored by:	trivago N.V.

Changes:
  head/net-mgmt/collectd5/Makefile
Comment 3 Luca Pizzamiglio freebsd_committer 2018-01-22 09:46:17 UTC
Committed.