Bug 225316 - net-mgmt/collectd5: Fix varnish plugin build
Summary: net-mgmt/collectd5: Fix varnish plugin build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-01-19 14:20 UTC by Luca Pizzamiglio
Modified: 2018-01-22 09:46 UTC (History)
1 user (show)

See Also:
linimon: maintainer-feedback+


Attachments
The fixing patch (436 bytes, patch)
2018-01-19 14:20 UTC, Luca Pizzamiglio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Pizzamiglio freebsd_committer 2018-01-19 14:20:42 UTC
Created attachment 189905 [details]
The fixing patch

Enabling the varnish plugin support, collectd5 fails to build during the configure phase, because the configure script is not able to find varnish headers.

The proposed patch remove the usage of --with-libvarnish=/usr/local that automatically set also CFLAGS=-I/usr/local/include (it should be /usr/local/include/varnish)

In this way, the configure script will use pkgconf that provides the correct value for LDFLAGS and CFLAGS.
Comment 1 Krzysztof 2018-01-19 20:20:14 UTC
Yes, I approve this patch.
Comment 2 commit-hook freebsd_committer 2018-01-22 09:44:56 UTC
A commit references this bug:

Author: pizzamig
Date: Mon Jan 22 09:44:43 UTC 2018
New revision: 459641
URL: https://svnweb.freebsd.org/changeset/ports/459641

Log:
  net-mgmt/collectd5: Fix varnish plugin build

  PR:		225316
  Approved by:	maintainer
  Sponsored by:	trivago N.V.

Changes:
  head/net-mgmt/collectd5/Makefile
Comment 3 Luca Pizzamiglio freebsd_committer 2018-01-22 09:46:17 UTC
Committed.